Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Open native context menu when editing Sticky #8370

Merged

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Jan 17, 2024

Summary

Right click a sticky

  • when not editing it should open n8n's context menu
  • when editing it should open the native context menu

Related tickets and issues

https://linear.app/n8n/issue/NODE-1060/canvas-context-menu-shows-when-editing-sticky-note

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 17, 2024
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jan 18, 2024

1 flaky test on run #3819 ↗︎

0 334 5 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project: n8n Commit: d1c9422d09
Status: Passed Duration: 03:24 💡
Started: Jan 18, 2024 1:25 PM Ended: Jan 18, 2024 1:29 PM
Flakiness  cypress/e2e/17-sharing.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Sharing > should work for admin role on credentials created by others (also can share it with themselves) Test Replay Screenshots Video

Review all test suite changes for PR #8370 ↗︎

@elsmr elsmr merged commit ade7d30 into master Jan 18, 2024
28 checks passed
@elsmr elsmr deleted the node-1060-canvas-context-menu-shows-when-editing-sticky-note branch January 18, 2024 14:14
@github-actions github-actions bot mentioned this pull request Jan 22, 2024
@janober
Copy link
Member

janober commented Jan 22, 2024

Got released with [email protected]

@github-actions github-actions bot mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants