Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change the UI text for some filter operations #8360

Merged
merged 4 commits into from
Jan 18, 2024
Merged

fix: Change the UI text for some filter operations #8360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3569c8e
suggested UI text changes for switch node and other filters
StarfallProjects Jan 17, 2024
9981bf9
Update packages/editor-ui/src/plugins/i18n/locales/en.json
StarfallProjects Jan 17, 2024
fe141e2
fix lint issue
StarfallProjects Jan 17, 2024
a8fd5eb
Merge branch 'switch-text-suggestions' of https://github.com/n8n-io/n…
StarfallProjects Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/editor-ui/src/plugins/i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2340,20 +2340,20 @@
"filter.operator.notRegex": "does not match regex",
"filter.operator.gt": "is greater than",
"filter.operator.lt": "is less than",
"filter.operator.gte": "is greater than or equal",
"filter.operator.lte": "is less than or equal",
"filter.operator.gte": "is greater than or equal to",
"filter.operator.lte": "is less than or equal to",
"filter.operator.after": "is after",
"filter.operator.before": "is before",
"filter.operator.afterOrEquals": "is after or equal",
"filter.operator.beforeOrEquals": "is before or equal",
"filter.operator.afterOrEquals": "is after or equal to",
"filter.operator.beforeOrEquals": "is before or equal to",
"filter.operator.true": "is true",
"filter.operator.false": "is false",
"filter.operator.lengthEquals": "length equal to",
"filter.operator.lengthNotEquals": "length not equal to",
"filter.operator.lengthGt": "length greater than",
"filter.operator.lengthLt": "length less than",
"filter.operator.lengthGte": "length greater than or equal",
"filter.operator.lengthLte": "length less than or equal",
"filter.operator.lengthGte": "length greater than or equal to",
"filter.operator.lengthLte": "length less than or equal to",
"filter.operator.empty": "is empty",
"filter.operator.notEmpty": "is not empty",
"filter.combinator.or": "OR",
Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Switch/V3/SwitchV3.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export class SwitchV3 implements INodeType {
// eslint-disable-next-line n8n-nodes-base/node-param-default-wrong-for-number
default: '={{}}',
description:
"The output's index to which send an input item, use expressions to calculate what input item should be routed to which output, expression must return a number",
'The output index to send the input item to. Use an expression to calculate which input item should be routed to which output. The expression must return a number.',
},
{
displayName: 'Routing Rules',
Expand Down
4 changes: 2 additions & 2 deletions packages/nodes-base/nodes/TheHiveProject/descriptions/filter.description.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ export const genericFiltersCollection: INodeProperties = {
description: 'Field is greater than value',
},
{
name: 'Greater Than Or Equal',
name: 'Greater Than Or Equal To',
value: '_gte',
description: 'Field is greater than or equal to value',
},
Expand All @@ -208,7 +208,7 @@ export const genericFiltersCollection: INodeProperties = {
description: 'Field is less than value',
},
{
name: 'Less Than Or Equal',
name: 'Less Than Or Equal To',
value: '_lte',
description: 'Field is less than or equal to value',
},
Expand Down
Loading