Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Microsoft SQL Node): Fix "Maximum call stack size exceeded" error on too many rows #8334

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix(Microsoft SQL Node): Fix "Maximum call stack size exceeded" error on too many rows #8334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/nodes-base/nodes/Microsoft/Sql/MicrosoftSql.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,6 @@ export class MicrosoftSql implements INodeType {
const pool = configurePool(credentials);
await pool.connect();

const returnItems: INodeExecutionData[] = [];
let responseData: IDataObject | IDataObject[] = [];

const items = this.getInputData();
Expand Down Expand Up @@ -327,12 +326,11 @@ export class MicrosoftSql implements INodeType {

const itemData = generatePairedItemData(items.length);

const executionData = this.helpers.constructExecutionMetaData(
const returnItems = this.helpers.constructExecutionMetaData(
this.helpers.returnJsonArray(responseData),
{ itemData },
);

returnItems.push(...executionData);
return [returnItems];
}
}
Loading