fix(editor): Capture indexed access expressions when building completions #8331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivov
commented
Jan 15, 2024
| if (dollarSignIndex === -1) { | ||
| userInput = userInput.replace(/^.+(\(|\[|{)/, ''); |
There was a problem hiding this comment.
Went through the referenced PR, but I cannot quite tell why we needed to strip parens here. Since parens are needed for indexed access expressions and since all tests still pass, it looks safe to remove. Else let me know.
n8n-assistant
bot
added
n8n team
2 flaky tests on run #3793 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Debug > should be able to debug executions |
Test Replay
Screenshots
Video
|
|
29-templates.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Templates > should save template id with the workflow |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8331 ↗︎
|
✅ All Cypress E2E specs passed |
ivov
deleted the
pay-1140-expressions-autocomplete-shows-array-methods-for-string
branch
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building completions, we currently capture indexed access expressions as the index at the end, causing array completions to be offered. This PR accounts for this case.
Follow-up to: #5695