Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add fallback resolver for langchain modules #8308

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Conversation

OlegIvaniv
Copy link
Contributor

Summary

Add fallback resolve function for Langchain Code node, to correctly resolve Langchain modules inside docker.

Related tickets and issues

@OlegIvaniv OlegIvaniv marked this pull request as ready for review January 11, 2024 16:07
Signed-off-by: Oleg Ivaniv <[email protected]>
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jan 11, 2024
Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in release image and it is working great.

Copy link

cypress bot commented Jan 12, 2024

2 flaky tests on run #3749 ↗︎

0 332 5 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Project: n8n Commit: 8e9c77ae98
Status: Passed Duration: 03:23 💡
Started: Jan 12, 2024 5:09 PM Ended: Jan 12, 2024 5:12 PM
Flakiness  17-sharing.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Sharing > should work for admin role on credentials created by others (also can share it with themselves) Test Replay Screenshots Video
Flakiness  29-templates.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Templates > should save template id with the workflow Test Replay Screenshots Video

Review all test suite changes for PR #8308 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@OlegIvaniv OlegIvaniv merged commit 851060d into master Jan 12, 2024
28 checks passed
@OlegIvaniv OlegIvaniv deleted the lc_sandbox_resolve branch January 12, 2024 17:33
netroy pushed a commit that referenced this pull request Jan 16, 2024
@github-actions github-actions bot mentioned this pull request Jan 16, 2024
@janober
Copy link
Member

janober commented Jan 16, 2024

Got released with [email protected]

@github-actions github-actions bot mentioned this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants