Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HTTP Request Node): Delete response.request only when it's a valid circular references #8293

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fix(HTTP Request Node): Delete response.request only when it's a valid circular references #8293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/HttpRequest/V1/HttpRequestV1.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -994,7 +994,7 @@ export class HttpRequestV1 implements INodeType {
}

response = response.value;
delete response.request;
if (response?.request?.constructor.name === 'ClientRequest') delete response.request;

const options = this.getNodeParameter('options', itemIndex, {});

Expand Down
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/HttpRequest/V2/HttpRequestV2.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1047,7 +1047,7 @@ export class HttpRequestV2 implements INodeType {
}

response = response.value;
delete response.request;
if (response?.request?.constructor.name === 'ClientRequest') delete response.request;

const options = this.getNodeParameter('options', itemIndex, {});

Expand Down
3 changes: 2 additions & 1 deletion packages/nodes-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1786,7 +1786,8 @@ export class HttpRequestV3 implements INodeType {

// eslint-disable-next-line prefer-const
for (let [index, response] of Object.entries(responses)) {
delete response.request;
if (response?.request?.constructor.name === 'ClientRequest') delete response.request;

if (this.getMode() === 'manual' && index === '0') {
// For manual executions save the first response in the context
// so that we can use it in the frontend and so make it easier for
Expand Down
Loading