Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Webhook Node): Fix handling of form-data files #8256

Merged
merged 2 commits into from
Jan 8, 2024
Merged

fix(Webhook Node): Fix handling of form-data files #8256

merged 2 commits into from
Jan 8, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Jan 8, 2024

Summary

Since this commit, we are incorrectly checking if form-data contains files.

Related tickets and issues

Fixes #8249
https://community.n8n.io/t/getting-an-error-as-soon-as-the-webhook-is-called/34865
https://community.n8n.io/t/webhook-doesnt-receive-files-anymore/34999
https://community.n8n.io/t/webhook-configuration/35010

Review / Merge checklist

  • PR title and summary are descriptive
  • Tests included

@netroy netroy changed the title fix(Webhook Node): Fix handling for form-data files fix(Webhook Node): Fix handling of form-data files Jan 8, 2024
@netroy netroy requested a review from michael-radency January 8, 2024 11:49
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Jan 8, 2024
Copy link
Contributor

@michael-radency michael-radency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Jan 8, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Jan 8, 2024

2 flaky tests on run #3646 ↗︎

0 330 5 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: d84f7b7cd4
Status: Passed Duration: 07:00 💡
Started: Jan 8, 2024 1:23 PM Ended: Jan 8, 2024 1:30 PM
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Screenshots Video
Flakiness  29-templates.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Templates > should save template id with the workflow Screenshots Video

Review all test suite changes for PR #8256 ↗︎

Copy link
Contributor

github-actions bot commented Jan 8, 2024

✅ All Cypress E2E specs passed

@netroy netroy merged commit fc29030 into master Jan 8, 2024
19 checks passed
@netroy netroy deleted the fix-8249 branch January 8, 2024 13:33
@github-actions github-actions bot mentioned this pull request Jan 9, 2024
@Joffcom
Copy link
Member

Joffcom commented Jan 9, 2024

Got released with [email protected]

@github-actions github-actions bot mentioned this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webhook trigger fails when sent a file in multipart/form-data
3 participants