fix(MySQL Node): Only escape table names when needed #8246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
maspio
approved these changes
Jan 10, 2024
|
✅ All Cypress E2E specs passed |
3 flaky tests on run #3701 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sharing > should work for admin role on credentials created by others (also can share it with themselves) |
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Screenshots
Video
|
|
29-templates.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Templates > should save template id with the workflow |
Screenshots
Video
|
|
Review all test suite changes for PR #8246 ↗︎
elsmr
deleted the
node-964-mysql-n8n-rejects-valid-identifiers-on-insert
branch
Merged
MiloradFilipovic
added a commit
that referenced
this pull request
Jan 11, 2024
* master: fix: Adjust cred setup telemetry (no-changelog) (#8294) fix(HTTP Request Node): Delete `response.request` only when it's a valid circular references (#8293) fix: Properly output saml validation errors (#8284) 🚀 Release 1.24.0 (#8290) feat(editor): Migrate deviceSupportHelpers mixin to useDeviceSupport composable (no-changelog) (#8289) fix: Store workflow settings when saving an execution (#8288) fix(MySQL Node): Only escape table names when needed (#8246) feat(Google Sheets Node): Add "By Name" option to selector for Sheets (#8241) feat(MongoDB Node): Add support for TLS (#8266) feat: Update @n8n/chat exports and add example images (no-changelog) (#8274) ci: Add support for optionally including ARM64 support in custom images (no-changelog) (#8286) ci: Update Cypress & increase amount of e2e containers (#8282) fix(Monday.com Node): Migrate to api 2023-10 (#8254)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Only escape table names when needed in the MySQL node. Also adds support for fully qualified identifiers like
See reproduction steps in linear.
Related tickets and issues
https://linear.app/n8n/issue/NODE-964/mysql-n8n-rejects-valid-identifiers-on-insert
https://community.n8n.io/t/mysql-node-insert-operation-unable-to-address-the-table-in-a-db/33399
Review / Merge checklist
(no-changelog)otherwise. (conventions)