-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): Move typeorm
operators from WaitTracker
to ExecutionRepository
(no-changelog)
#8163
Merged
ivov
merged 7 commits into
master
from
move-typeorm-operators-from-waittracker-to-execution-repository
Dec 28, 2023
Merged
refactor(core): Move typeorm
operators from WaitTracker
to ExecutionRepository
(no-changelog)
#8163
ivov
merged 7 commits into
master
from
move-typeorm-operators-from-waittracker-to-execution-repository
Dec 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tionRepository` (no-changelog)
netroy
reviewed
Dec 27, 2023
n8n-assistant
bot
added
core
Enhancement outside /nodes-base and /editor-ui
n8n team
Authored by the n8n team
labels
Dec 27, 2023
netroy
reviewed
Dec 27, 2023
packages/cli/test/unit/repositories/execution.repository.test.ts
Outdated
Show resolved
Hide resolved
netroy
reviewed
Dec 28, 2023
packages/cli/test/unit/repositories/execution.repository.test.ts
Outdated
Show resolved
Hide resolved
…ors-from-waittracker-to-execution-repository
netroy
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
1 flaky test on run #3531 ↗︎
Details:
cypress/e2e/29-templates.cy.ts • 1 flaky test
Review all test suite changes for PR #8163 ↗︎ |
✅ All Cypress E2E specs passed |
ivov
deleted the
move-typeorm-operators-from-waittracker-to-execution-repository
branch
December 28, 2023 18:22
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to: #8145