Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Replace some of the Container.get calls with DI, and break a few more circular dependencies (no-changelog) #8135

Closed
wants to merge 1 commit into from
Closed

refactor(core): Replace some of the Container.get calls with DI, and break a few more circular dependencies (no-changelog) #8135

wants to merge 1 commit into from

Conversation

netroy
Copy link
Member

@netroy netroy commented Dec 21, 2023

General janitorial work

Review / Merge checklist

  • PR title and summary are descriptive
  • Tests included

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Dec 21, 2023
tomi
tomi previously approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👏 I was actually going to ask why are we using Container.get in so many places instead of injecting in the constructor, but this clarifies it.

Couple minor comments, but LGTM 🚀

packages/cli/src/InternalHooks.ts Show resolved Hide resolved
packages/cli/src/environments/sourceControl/sourceControlPreferences.service.ee.ts Show resolved Hide resolved
packages/cli/test/unit/CredentialsHelper.test.ts Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@netroy netroy marked this pull request as draft December 22, 2023 11:38
@netroy
Copy link
Member Author

netroy commented Dec 22, 2023

This PR has spiraled out a bit. Going to split this out into separate PRs

@netroy netroy closed this Dec 22, 2023
@netroy netroy mentioned this pull request Dec 22, 2023
Merged
1 task
netroy added a commit that referenced this pull request Dec 22, 2023
@netroy
refactor(core): Move all base URLs to UrlService (no-changelog) (#8141)
baee47a 
This change kept coming up in #6713, #7773, and #8135. 
So this PR moves the existing code without actually changing anything,
to help get rid of some of the circular dependencies.


## Review / Merge checklist
- [x] PR title and summary are descriptive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivov ivov ivov left review comments

@tomi tomi tomi left review comments

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netroy @tomi @ivov