refactor(core): Move active workflows endpoints to a decorated controller class (no-changelog) #8101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
…ller class (no-changelog)
netroy
force-pushed
the
refactor-active-workflows-endpoints
branch
from
4a5f232 to
88b92df
Compare
3 flaky tests on run #3470 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sharing > should work for admin role on credentials created by others (also can share it with themselves) |
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Screenshots
Video
|
|
27-two-factor-authentication.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Two-factor authentication > Should be able to login with MFA token |
Screenshots
Video
|
|
Review all test suite changes for PR #8101 ↗︎
ivov
reviewed
Dec 22, 2023
| userId: user.id, | ||
| }); | ||
|
|
||
| throw new BadRequestError(`Workflow with ID "${workflowId}" could not be found.`); |
There was a problem hiding this comment.
For learning - I'd've used at BadRequestError and other response errors only at controller level. It's okay to use them at service level?
There was a problem hiding this comment.
I have conflicting opinions about this. one one hand all communication layer details should be abstracted away in the controllers, on the other hand letting services throw these error makes the code a lot simpler and easier to maintain 🤷🏽.
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Dec 22, 2023
* master: feat(core): Unify application components shutdown (#8097) refactor(core): Upgrade more dependencies to remove axios 0.x (no-changelog) (#8105) refactor(core): Move active workflows endpoints to a decorated controller class (no-changelog) (#8101) fix(editor): Prevent canvas undo/redo when NDV is open (#8118) fix(editor): Fix operation change failing in certain conditions (#8114) fix(Asana Node): Omit body from GET, HEAD, and DELETE requests (#8057) fix(Redis Trigger Node): Activating a workflow with a Redis trigger fails (#8129) refactor(Peekalink Node): Stricter typing for Peekalink api call + Tests (no-changelog) (#8125) fix(core): Remove circular dependency in WorkflowService and ActiveWorkflowRunner (#8128) fix: Show public API upgrade CTA when feature is not enabled (#8109) feat(Snowflake Node): Update snowflake-sdk (no-changelog) (#8087) fix(core): Handle empty executions table in pruning in migrations (#8121) feat(core): Add closeFunction support to Sub-Nodes (#7708) refactor(core): Move error execution creation to execution service (no-changelog) (#8006) ci: Add lint rule `no-dynamic-import-template` (no-changelog) (#8089) feat(core): Remove discontinued crypto-js (#8104) 🚀 Release 1.22.0 (#8115) fix(core): Prevent axios from force setting a form-urlencoded content-type (#8117) feat(Respond to Webhook Node): Overhaul with improvements like returning all items (#8093)
jamesfdavis
added a commit
to jamesfdavis/n8n
that referenced
this pull request
Dec 24, 2023
* upstream/master: (32 commits) refactor(core): Move `typeorm` operators from `PruningService` to `ExecutionRepository` (no-changelog) (n8n-io#8145) refactor(core): Move more `typeorm` operators to repositories (no-changelog) (n8n-io#8143) refactor(core): Delete unused code, and fix typings in tests (no-changelog) (n8n-io#8142) docs: Improve documentation for the toTitleCase function (no-changelog) (n8n-io#8140) refactor(core): Move all base URLs to UrlService (no-changelog) (n8n-io#8141) feat(editor): Add template Id to workflow metadata (n8n-io#8088) fix(editor): Avoid sanitizing output to search node data (n8n-io#8126) fix(editor): Prevent browser zoom when scrolling inside sticky edit mode (n8n-io#8116) refactor(core): Move some `typeorm` operators to repositories (no-changelog) (n8n-io#8139) feat(editor): Add node execution status indicator to output panel (n8n-io#8124) feat(core): Unify application components shutdown (n8n-io#8097) refactor(core): Upgrade more dependencies to remove axios 0.x (no-changelog) (n8n-io#8105) refactor(core): Move active workflows endpoints to a decorated controller class (no-changelog) (n8n-io#8101) fix(editor): Prevent canvas undo/redo when NDV is open (n8n-io#8118) fix(editor): Fix operation change failing in certain conditions (n8n-io#8114) fix(Asana Node): Omit body from GET, HEAD, and DELETE requests (n8n-io#8057) fix(Redis Trigger Node): Activating a workflow with a Redis trigger fails (n8n-io#8129) refactor(Peekalink Node): Stricter typing for Peekalink api call + Tests (no-changelog) (n8n-io#8125) fix(core): Remove circular dependency in WorkflowService and ActiveWorkflowRunner (n8n-io#8128) fix: Show public API upgrade CTA when feature is not enabled (n8n-io#8109) ...
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a continuation of migrating all rest endpoints to decorated controller classes
Review / Merge checklist