Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Stop binary data restoration from preventing execution from finishing #8082

Merged
merged 5 commits into from
Dec 21, 2023
Merged

fix(core): Stop binary data restoration from preventing execution from finishing #8082

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5e632ca
fix: Prevent binary data restoration from preventing execution from f…
krynble Dec 19, 2023
a7898e6
refactor: Change logging level to error
krynble Dec 19, 2023
944f6c6
refactor(core): Suggestions for #8082
ivov Dec 19, 2023
66b8ef2
Update packages/cli/src/executionLifecycleHooks/restoreBinaryDataId.ts
krynble Dec 20, 2023
ddc2051
fix: Lint issue
krynble Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/cli/src/WorkflowExecuteAdditionalData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,14 @@ function hookFunctionsSave(parentProcessMode?: string): IWorkflowExecuteHooks {
workflowId: this.workflowData.id,
});

await restoreBinaryDataId(fullRunData, this.executionId, this.mode);
try {
await restoreBinaryDataId(fullRunData, this.executionId, this.mode);
} catch (e) {
logger.debug('Failed to restore binary data ID', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to handle only the specific error here instead of everything.

Also, since this isn't really something that is expected, wouldn't we want to log this either as an error or warning?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, Tomi - changed the level to errror

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed - looks good? Would you mind approving?

executionId: this.executionId,
mode: this.mode,
});
}
ivov marked this conversation as resolved.
Show resolved Hide resolved

const isManualMode = [this.mode, parentProcessMode].includes('manual');

Expand Down