Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Asana Node): Omit body from GET, HEAD, and DELETE requests #8057

Merged
merged 4 commits into from
Dec 21, 2023
Merged

fix(Asana Node): Omit body from GET, HEAD, and DELETE requests #8057

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cfb20ef
fix(Asana Node): Omit body from GET and HEAD requests
aarongut Dec 15, 2023
0ee6a4f
lint fix
aarongut Dec 16, 2023
12e124d
Merge branch 'master' of github.com:n8n-io/n8n
aarongut Dec 20, 2023
cb3b63d
Include DELETE as well
aarongut Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Asana/GenericFunctions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
const options: IHttpRequestOptions = {
headers: {},
method,
body: { data: body },
body: (method === 'GET' || method === 'HEAD') ? null : { data: body },

Check failure on line 30 in packages/nodes-base/nodes/Asana/GenericFunctions.ts

View workflow job for this annotation

GitHub Actions / Lint changes 

Replace `(method·===·'GET'·||·method·===·'HEAD')` with `method·===·'GET'·||·method·===·'HEAD'`
qs: query,
url: uri || `https://app.asana.com/api/1.0${endpoint}`,
json: true,
Expand Down
Loading