fix(editor): Update wording when an instance owner or admin is viewing a credential they do not own #8054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g a credential they do not own
n8n-assistant
bot
added
n8n team
krynble
approved these changes
Dec 18, 2023
Passing run #3374 ↗︎
Details:
Review all test suite changes for PR #8054 ↗︎ |
|||||||||||||||
|
✅ All Cypress E2E specs passed |
krynble
deleted the
pay-1143-update-wording-when-an-instance-owner-or-admin-is-viewing-a
branch
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that instance admins and owners can share on credentials, we need to tweak the wording so it's clear what they can do in the UI and the access they have.
Acceptance Criteria
When an instance owner/admin views a credential they do not own, we should show the following text
You can view this credential because you have permission to read and share (and rename or delete it too).When an instance owner/admin views a credential they do not own and has NOT been shared with them, we should show the following text
You can view this credential because you have permission to read and share (and rename or delete it too). You can share it with yourself or other users to use it in a workflow.