Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Two small UI copy fixes in sub-nodes #8032

Merged
merged 1 commit into from
Dec 14, 2023
Merged

docs: Two small UI copy fixes in sub-nodes #8032

merged 1 commit into from
Dec 14, 2023

Conversation

StarfallProjects
Copy link
Contributor

Summary

Fix UI copy in the SerpAPI and Item List Output Parser nodes

Copy link

cypress bot commented Dec 14, 2023

2 flaky tests on run #3347 ↗︎

0 305 5 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 StarfallProjects 🗃️ e2e/*
Project: n8n Commit: cf1f12edb5
Status: Passed Duration: 06:49 💡
Started: Dec 14, 2023 6:47 PM Ended: Dec 14, 2023 6:54 PM
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Screenshots Video
Flakiness  27-two-factor-authentication.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Two-factor authentication > Should be able to login with MFA token Screenshots Video

Review all test suite changes for PR #8032 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Dec 14, 2023
@Joffcom Joffcom merged commit f432d86 into master Dec 14, 2023
19 checks passed
@Joffcom Joffcom deleted the ui-copy-fixes branch December 14, 2023 19:15
MiloradFilipovic added a commit that referenced this pull request Dec 15, 2023
* master:
  refactor(core): Warn on sqlite DB detected during init on queue mode (#8034)
  docs: Two small UI copy fixes in sub-nodes (#8032)
  fix(core): Restore workflow ID during execution creation (#8031)
  fix(core): Initialize queue once in queue mode (#8025)
  fix(editor): Add back credential `use` permission (#8023)
  fix(editor): Disable auto scroll and list size check when clicking on executions (#7983)
  fix(editor): Fix dialogVisibleChanged hooks event when meta.value is undefined (no-changelog) (#7986)
  perf(editor): Improve canvas rendering performance (#8022)
@janober
Copy link
Member

janober commented Dec 15, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants