fix(cli): reject webhooks with unsupported content types #8029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is no actual body, the content-type doesn't matter. This way, the webhook is not started with an empty body. To be backwards compatible, we should maybe only throw if an option on the node is enabled.
Will format in next commit. By using early return, the code is less nested and is easier to follow
|
|
n8n-assistant
bot
added
community
netroy
reviewed
Dec 19, 2023
There was a problem hiding this comment.
Thanks for doing this @entropitor, but we recently changed Webhook nodes to automatically create binary-data when the content-type is missing or invalid.
In scenarios like this, we expect the end user to use a Convert to/from binary data to parse the payload.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is no actual body, the content-type doesn't matter. This way, the webhook is not started with an empty body.
To be backwards compatible, we should maybe only throw if an option on the node is enabled (maybe some workflows don't care about the body and will break if we merge this as if). WDYT?
Summary
If webhook requests come in with an unsupported content-type, the request get rejected. Before this change, the request would be accepted and the workflow would start without a body property as non of the branches would trigger. This can cause hard to understand workflow failures.
Related tickets and issues
Fixes #7700
Fixes NODE-927
Review / Merge checklist
(no-changelog)otherwise. (conventions)