Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Fix collection select label (no-changelog) #7978

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix(editor): Fix collection select label (no-changelog) #7978

merged 1 commit into from
Dec 11, 2023

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Dec 11, 2023 •
edited
Loading

Summary

before & after

image

image

How to test the change:

  1. Add Pipedrive > Create Deal
  2. Click on "Add Field" under "Additional Fields"
  3. Options should be properly displayed (Title case)

Issues fixed

https://linear.app/n8n/issue/NODE-977

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests.

    (internal) You can use Slack commands to trigger e2e tests or deploy test instance or deploy early access version on Cloud.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 11, 2023
@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@cypress Cypress
Copy link

cypress bot commented Dec 11, 2023

Passing run #3286 ↗︎

0 294 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project: n8n Commit: aa12925c7a
Status: Passed Duration: 06:27 💡
Started: Dec 11, 2023 7:52 AM Ended: Dec 11, 2023 7:59 AM

Review all test suite changes for PR #7978 ↗︎

@elsmr elsmr merged commit 939e471 into master Dec 11, 2023
20 checks passed
@elsmr elsmr deleted the node-977-all-node-options-are-messed-up branch December 11, 2023 08:50
@janober
Copy link
Member

janober commented Dec 13, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-radency michael-radency michael-radency approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elsmr @janober @michael-radency