Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Run dev command only for core packages (no-changelog) #7928

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

alexgrozav
Copy link
Member

Summary

Provide details about your pull request and what it adds, fixes, or changes. Photos and videos are recommended.

  • Filters out @n8n/chat and n8n-design-system from pnpm run dev
  • Fixes dev/build error appearing due to code string import ... from '@n8n/chat'

How to test the change:

  1. pnpm run dev should work as expected
  2. The command should not run for the two packages above
  3. The error regarding @n8n/chat should no longer appear

Issues fixed

Include links to Github issue or Community forum post or Linear ticket:

Important in order to close automatically and provide context to reviewers

https://linear.app/n8n/issue/PAY-1089/run-dev-command-only-for-core-packages

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included. N/A

    A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests.

    (internal) You can use Slack commands to trigger e2e tests or deploy test instance or deploy early access version on Cloud.

@alexgrozav alexgrozav self-assigned this Dec 5, 2023
@alexgrozav alexgrozav changed the title feat: Run dev command only for core packages (no-changelog) fix: Run dev command only for core packages (no-changelog) Dec 5, 2023
@alexgrozav alexgrozav requested a review from netroy December 5, 2023 10:30
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 5, 2023
@ivov
Copy link
Contributor

ivov commented Dec 5, 2023

Adi is OOO - quick question, why don't we want dev for design-system? We'll have to rebuild for every change when making a DS component?

@alexgrozav
Copy link
Member Author

Adi is OOO - quick question, why don't we want dev for design-system? We'll have to rebuild for every change when making a DS component?

Design system's npm run dev only starts storybook. The design system's source files are referenced directly in editor-ui so you'll get the latest version of the code at any time.

Copy link

cypress bot commented Dec 5, 2023

1 flaky test on run #3200 ↗︎

0 297 5 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project: n8n Commit: 77fea106e2
Status: Passed Duration: 06:37 💡
Started: Dec 5, 2023 4:49 PM Ended: Dec 5, 2023 4:56 PM
Flakiness  cypress/e2e/26-resource-locator.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Resource Locator > should retrieve list options when other params throw errors Screenshots Video

Review all test suite changes for PR #7928 ↗︎

Copy link
Contributor

github-actions bot commented Dec 5, 2023

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit 92fa623 into master Dec 6, 2023
19 checks passed
@alexgrozav alexgrozav deleted the pay-1089-run-dev-command-only-for-core-packages branch December 6, 2023 15:28
@janober
Copy link
Member

janober commented Dec 13, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants