Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Create PR template (no-changelog) #7902

Merged
merged 9 commits into from
Dec 1, 2023
Merged

docs: Create PR template (no-changelog) #7902

merged 9 commits into from
Dec 1, 2023

Conversation

mutdmour
Copy link
Contributor

@mutdmour mutdmour commented Dec 1, 2023 •
edited
Loading

Summary

Provide details about your pull request and what it adds, fixes, or changes. Photos and videos are recommended.
Add PR template

How to test the change:

  1. Create new PR.

Issues fixed

Include links to Github issue or Community forum post or Linear ticket:

Important in order to close automatically and provide context to reviewers

ADO-1200

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (convetions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A feature is not complete without tests.
    A bug is not considered fixed, unless a test is added to prevent it from happening again.

    (internal) You can use Slack commands to trigger e2e tests or deploy test instance or deploy early access version on Cloud.

@mutdmour mutdmour changed the title chore: Create PR template (no-changelog) docs: Create PR template (no-changelog) Dec 1, 2023
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Dec 1, 2023
tomi
tomi previously approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🥳 Thanks for improving it

.github/pull_request_template.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress Cypress
Copy link

cypress bot commented Dec 1, 2023

1 failed test on run #3159 ↗︎

1 296 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 mutdmour 🗃️ e2e/*
Project: n8n Commit: 542757ed40
Status: Failed Duration: 06:38 💡
Started: Dec 1, 2023 3:03 PM Ended: Dec 1, 2023 3:09 PM
Failed  cypress/e2e/27-two-factor-authentication.cy.ts • 1 failed test

View Output Video

Test Artifacts
Two-factor authentication > Should be able to login with MFA token Screenshots Video

Review all test suite changes for PR #7902 ↗︎

tomi
tomi previously approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

.github/pull_request_title_conventions.md
@@ -0,0 +1,112 @@
# PR Title Convention
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

tomi
tomi previously approved these changes Dec 1, 2023
View reviewed changes
@mutdmour mutdmour merged commit 403ba6e into master Dec 1, 2023
4 checks passed
@mutdmour mutdmour deleted the ado-1200 branch December 1, 2023 15:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

✅ All Cypress E2E specs passed

MiloradFilipovic added a commit that referenced this pull request Dec 1, 2023
@MiloradFilipovic
Merge branch 'master' into speed-up-opening-workflows
43d17ac 
* master:
  perf(editor): Improve node rendering performance when opening large workflows (#7904)
  docs: Create PR template (no-changelog) (#7902)
  fix(editor): Tune styles of template credential setup (no-changelog) (#7898)

# Conflicts:
#	packages/editor-ui/src/views/NodeView.vue
@janober
Copy link
Member

janober commented Dec 6, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomi tomi tomi left review comments

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mutdmour @janober @tomi