Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BambooHR Node): Add support for Only Current on company reports #7878

Merged
merged 1 commit into from
Dec 5, 2023
Merged

feat(BambooHR Node): Add support for Only Current on company reports #7878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/nodes-base/nodes/BambooHr/v1/actions/companyReport/get/description.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,13 @@ export const companyReportGetDescription: INodeProperties[] = [
default: true,
description: 'Whether to apply the standard duplicate field filtering or not',
},
{
displayName: 'Only Current',
name: 'onlyCurrent',
type: 'boolean',
default: true,
description: 'Whether to hide future dated values from the history table fields or not',
},
],
},
];
3 changes: 2 additions & 1 deletion packages/nodes-base/nodes/BambooHr/v1/actions/companyReport/get/execute.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,10 @@ export async function get(this: IExecuteFunctions, index: number) {
const reportId = this.getNodeParameter('reportId', index) as string;
const format = this.getNodeParameter('format', 0) as string;
const fd = this.getNodeParameter('options.fd', index, true) as boolean;
const onlyCurrent = this.getNodeParameter('options.onlyCurrent', index, true) as boolean;

//endpoint
const endpoint = `reports/${reportId}/?format=${format}&fd=${fd}`;
const endpoint = `reports/${reportId}/?format=${format}&fd=${fd}&onlyCurrent=${onlyCurrent}`;

if (format === 'JSON') {
const responseData = await apiRequest.call(
Expand Down
Loading