refactor: Remove Epub document loader override (no-changelog) #7874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleg Ivaniv <[email protected]>
netroy
approved these changes
Nov 30, 2023
1 flaky test on run #3131 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Resource Locator > should retrieve list options when other params throw errors |
Screenshots
Video
|
|
Review all test suite changes for PR #7874 ↗︎
|
✅ All Cypress E2E specs passed |
OlegIvaniv
added a commit
that referenced
this pull request
Dec 4, 2023
- Remove Epub document loader override, use standard Langchain loader - Use temporary buffer file for document loader processing and pass just the path - Remove replace `@gxl/epub-parser` library with `epub2` Github issue / Community forum post (link here to close automatically): --------- Signed-off-by: Oleg Ivaniv <[email protected]> Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
ivov
pushed a commit
that referenced
this pull request
Dec 5, 2023
- Remove Epub document loader override, use standard Langchain loader - Use temporary buffer file for document loader processing and pass just the path - Remove replace `@gxl/epub-parser` library with `epub2` Github issue / Community forum post (link here to close automatically): --------- Signed-off-by: Oleg Ivaniv <[email protected]> Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gxl/epub-parserlibrary withepub2Github issue / Community forum post (link here to close automatically):