Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Switch plain errors in cli to ApplicationError #7857

Merged
merged 2 commits into from
Nov 29, 2023
Merged

refactor(core): Switch plain errors in cli to ApplicationError #7857

merged 2 commits into from
Nov 29, 2023

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Nov 29, 2023

Ensure all errors in cli are ApplicationError or children of it and contain no variables in the message, to continue normalizing all the errors we report to Sentry

Follow-up to: #7839

@ivov ivov requested a review from a team as a code owner November 29, 2023 09:29
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Nov 29, 2023
netroy
netroy requested changes Nov 29, 2023
View reviewed changes
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this 🙏🏽

packages/cli/src/environments/sourceControl/sourceControlPreferences.service.ee.ts Outdated Show resolved Hide resolved
packages/cli/src/services/dynamicNodeParameters.service.ts Outdated Show resolved Hide resolved
@cypress Cypress
Copy link

cypress bot commented Nov 29, 2023

Passing run #3103 ↗︎

0 288 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project: n8n Commit: 20916cd98e
Status: Passed Duration: 05:54 💡
Started: Nov 29, 2023 11:09 AM Ended: Nov 29, 2023 11:15 AM

Review all test suite changes for PR #7857 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit c08c5cc into master Nov 29, 2023
22 checks passed
@ivov ivov deleted the switch-plain-errors-in-cli-to-application-error branch November 29, 2023 11:25
@ivov ivov mentioned this pull request Nov 29, 2023
Merged
ivov added a commit that referenced this pull request Nov 30, 2023
@ivov
refactor(core): Switch plain errors in core to ApplicationError (…
b16dd21 
…no-changelog) (#7873)

Ensure all errors in `core` are `ApplicationError` or children of it and
contain no variables in the message, to continue normalizing all the
errors we report to Sentry

Follow-up to: #7857
@janober
Copy link
Member

janober commented Dec 1, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivov @janober @netroy