Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Upgrade to pnpm 8.9 (no-changelog) #7393

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Oct 10, 2023

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (fbcd1d4) 33.40% compared to head (3451ad5) 33.42%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7393      +/-   ##
==========================================
+ Coverage   33.40%   33.42%   +0.01%     
==========================================
  Files        3389     3389              
  Lines      206627   206654      +27     
  Branches    22307    22302       -5     
==========================================
+ Hits        69032    69074      +42     
+ Misses     136477   136460      -17     
- Partials     1118     1120       +2     
Files Coverage Δ
...src/executionLifecycleHooks/restoreBinaryDataId.ts 93.33% <100.00%> (-0.42%) ⬇️
packages/cli/src/workflows/workflows.services.ts 56.04% <100.00%> (+0.98%) ⬆️
packages/core/src/BinaryData/errors.ts 50.00% <75.00%> (ø)
packages/core/src/BinaryData/utils.ts 81.25% <85.71%> (+7.91%) ⬆️
packages/core/src/index.ts 0.00% <0.00%> (ø)
packages/core/src/BinaryData/BinaryData.service.ts 38.59% <71.42%> (+0.87%) ⬆️
packages/core/src/BinaryData/FileSystem.manager.ts 88.63% <88.88%> (+39.98%) ⬆️
...odeNodeEditor/completions/jsonField.completions.ts 21.53% <0.00%> (-0.62%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Oct 10, 2023

2 flaky tests on run #2450 ↗︎

0 250 0 0 Flakiness 2

Details:

🌳 upgrade-to-pnpm-8.9 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project: n8n Commit: 3451ad52e5
Status: Passed Duration: 08:53 💡
Started: Oct 10, 2023 9:35 AM Ended: Oct 10, 2023 9:44 AM
Flakiness  26-resource-locator.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Resource Locator > should retrieve list options when other params throw errors Output Screenshots Video
Flakiness  27-two-factor-authentication.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Two-factor authentication > Should be able to login with MFA token Output Screenshots Video

Review all test suite changes for PR #7393 ↗︎

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit 5c70704 into master Oct 10, 2023
54 of 55 checks passed
@ivov ivov deleted the upgrade-to-pnpm-8.9 branch October 10, 2023 10:07
MiloradFilipovic added a commit that referenced this pull request Oct 10, 2023
* master: (42 commits)
  fix(editor): Make workflow history button available only for dev builds (#7392)
  refactor: Upgrade to pnpm 8.9 (no-changelog) (#7393)
  ci: Identify NPM releases as `stable` (no-changelog)
  fix(editor): Implement canvas zoom UX improvements (#7376)
  feat(core): Switch binary filesystem mode to nested path structure (#7307)
  fix(editor): Fix completions for `.json` on quoted node name in Code node (#7382)
  fix(Notion Node): Handle empty values correctly for Notion selects + multi selects (#7383)
  feat(editor): Make PDF and Audio binary-data viewable in the UI (#7367)
  fix(Google Sheets Node): Fix "Maximum call stack size exceeded" error on too many rows (#7384)
  refactor(core): Refactor nodes loading (no-changelog) (#7283)
  fix(core): Add an option to enable postgres ssl with default certs (#6889)
  feat(editor): Workflow history [WIP]- Add restore and clone into new workflow actions (no-changelog) (#7359)
  fix(HTML Node): Update property fields to not use expressions on drag (#7379)
  fix: Add role check for upgrade path (#7374)
  fix(editor): Remove excess margin below run data editor (#7372)
  fix(Google Drive Trigger Node): Add Shared Drives support (#7369)
  feat(core): Add Job Summary to Worker response (#7360)
  feat(Execute Workflow Node): Run once for each item mode (#7289)
  refactor(core): Move `copyInputItems` to node helpers (no-changelog) (#7299)
  refactor(core): Create controller for binary data (no-changelog) (#7363)
  ...

# Conflicts:
#	cypress/e2e/5-ndv.cy.ts
@janober
Copy link
Member

janober commented Oct 11, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants