Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Attempt license renewal when n8n starts (no-changelog) #7204

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

csuermann
Copy link
Contributor

This change is needed so that the newly introduced floating licenses will be attempted to be claimed when n8n starts up.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (9f797b9) 32.65% compared to head (b6013e7) 32.65%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7204      +/-   ##
==========================================
- Coverage   32.65%   32.65%   -0.01%     
==========================================
  Files        3340     3340              
  Lines      199463   199463              
  Branches    21845    21844       -1     
==========================================
- Hits        65132    65131       -1     
- Misses     133251   133252       +1     
  Partials     1080     1080              
Files Changed Coverage Δ
packages/cli/src/License.ts 51.75% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csuermann csuermann requested review from flipswitchingmonkey and krynble and removed request for flipswitchingmonkey September 19, 2023 08:41
@cypress
Copy link

cypress bot commented Sep 19, 2023

1 flaky test on run #2209 ↗︎

0 238 3 0 Flakiness 1

Details:

🌳 renew-license-on-init 🖥️ browsers:node18.12.0-chrome107 🤖 csuermann 🗃️ e2e...
Project: n8n Commit: b6013e7dda
Status: Passed Duration: 08:05 💡
Started: Sep 19, 2023 9:59 AM Ended: Sep 19, 2023 10:07 AM
Flakiness  cypress/e2e/26-resource-locator.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Resource Locator > should retrieve list options when other params throw errors Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@csuermann csuermann merged commit 050ba70 into master Sep 19, 2023
18 checks passed
@csuermann csuermann deleted the renew-license-on-init branch September 19, 2023 10:10
MiloradFilipovic added a commit that referenced this pull request Sep 20, 2023
* master:
  refactor(core): Implement soft-deletions for executions (#7092)
  docs(Google Sheets Node): Operations naming update (no-changelog) (#7211)
  fix(core): Make parsing of content-type and content-disposition headers more flexible (#7217)
  fix(HTML Node): Add pairedItem support for 'Convert to HTML Table' operation (#7196)
  fix(HTTP Request Node): Decrease default timeout to 5min (#7177)
  feat(Linear Node): Add support for OAuth2 (#7201)
  refactor: Ignore large-scale revisions (no-changelog) (#7210)
  fix(core): Resolve domains to IPv4 first (#7206)
  ci: Fix tests failing on MySQL (no-changelog) (#7208)
  feat(Set Node): Overhaul (#6348)
  fix: Attempt license renewal when n8n starts (no-changelog) (#7204)
@janober
Copy link
Member

janober commented Sep 21, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants