Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add "Sent by n8n" attribution #7183

Merged
merged 18 commits into from
Oct 3, 2023

Conversation

michael-radency
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@michael-radency michael-radency added node/improvement New feature or request n8n team Authored by the n8n team labels Sep 15, 2023
@michael-radency michael-radency changed the title feat:(core): Add "Sent by n8n" attribution feat(core): Add "Sent by n8n" attribution Sep 15, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Attention: 88 lines in your changes are missing coverage. Please review.

Comparison is base (e7a90c7) 33.30% compared to head (0f8ed30) 33.28%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7183      +/-   ##
==========================================
- Coverage   33.30%   33.28%   -0.02%     
==========================================
  Files        3376     3376              
  Lines      205691   205756      +65     
  Branches    22140    22152      +12     
==========================================
- Hits        68498    68494       -4     
- Misses     136080   136149      +69     
  Partials     1113     1113              
Files Coverage Δ
packages/editor-ui/src/constants.ts 99.68% <100.00%> (+<0.01%) ⬆️
...kages/nodes-base/nodes/EmailSend/EmailSend.node.ts 0.00% <ø> (ø)
.../nodes-base/nodes/EmailSend/v2/EmailSendV2.node.ts 0.00% <ø> (ø)
...ckages/nodes-base/nodes/Google/Gmail/Gmail.node.ts 0.00% <ø> (ø)
...s-base/nodes/Google/Gmail/v2/MessageDescription.ts 0.00% <ø> (ø)
...nodes/Microsoft/Teams/ChannelMessageDescription.ts 0.00% <ø> (ø)
...se/nodes/Microsoft/Teams/ChatMessageDescription.ts 0.00% <ø> (ø)
...es/nodes-base/nodes/Slack/V2/MessageDescription.ts 0.00% <ø> (ø)
packages/workflow/src/Interfaces.ts 77.77% <ø> (ø)
packages/core/src/NodeExecuteFunctions.ts 18.74% <50.00%> (-0.02%) ⬇️
... and 10 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Oct 3, 2023

1 flaky test on run #2349 ↗︎

0 242 3 0 Flakiness 1

Details:

🌳 node-687-add-sent-by-n8n-attribution 🖥️ browsers:node18.12.0-chrome107 🤖 mi...
Project: n8n Commit: 0f8ed30086
Status: Passed Duration: 07:51 💡
Started: Oct 3, 2023 8:09 AM Ended: Oct 3, 2023 8:17 AM
Flakiness  cypress/e2e/24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Output Screenshots Video

Review all test suite changes for PR #7183 ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 8f9fe62 into master Oct 3, 2023
20 checks passed
@michael-radency michael-radency deleted the node-687-add-sent-by-n8n-attribution branch October 3, 2023 08:19
@github-actions github-actions bot mentioned this pull request Oct 4, 2023
krynble added a commit that referenced this pull request Oct 5, 2023
# [1.10.0](https://github.com/n8n-io/n8n/compare/[email protected]@1.10.0)
(2023-10-05)


### Bug Fixes

* **Convert to/from binary data Node:** Rename 'Move Binary Data' to
'Convert to/from binary data'
([#7318](#7318))
([5e6c1d4](5e6c1d4))
* **core:** Account for itemless case on restoring binary data ID
([#7305](#7305))
([1691223](1691223))
* **core:** Fix pruning of non-finished executions
([#7333](#7333))
([1b4848a](1b4848a))
* **editor:** Disable email confirmation banner for trialing users
([#7340](#7340))
([6d3d178](6d3d178))
* **editor:** Display value of selected matching column in RMC
([#7298](#7298))
([3aac22b](3aac22b))
* **editor:** Fix canvas endpoint snapping when dragging connection
([#7346](#7346))
([b59b908](b59b908))
* **editor:** Fix disappearing NDV header in code nodes
([#7290](#7290))
([7ebf8f3](7ebf8f3))
* **editor:** Fix RLC not loading when an expression can't resolve
([#7295](#7295))
([ddc26c2](ddc26c2))
* **editor:** Separate cloud endpoint calls
([#7312](#7312))
([04dfcd7](04dfcd7))
* **Jira Software Node:** Get all users in dropdown/RLC
([#7322](#7322))
([3704760](3704760)),
closes [#2670](#2670)
* **Notion Node:** Rename Notion API Key to Internal Integration Token
([#7176](#7176))
([ec2aa38](ec2aa38))
* **Postgres Node:** Node requires comma-separated string even when
using a single parameter through an expression
([#7300](#7300))
([763d451](763d451))
* **Set Node:** Do not stringify null and undefined
([#7313](#7313))
([f0a6687](f0a6687))
* **Typeform Trigger Node:** Change output format for TypeForm trigger
to object instead of array
([#7315](#7315))
([b3fc00e](b3fc00e))


### Features

* **core:** Add "Sent by n8n" attribution
([#7183](#7183))
([8f9fe62](8f9fe62))
* **core:** Add support for building LLM applications
([#7235](#7235))
([00a4b8b](00a4b8b)),
closes [#7246](#7246)
[#7137](#7137)
* Workflow History pruning and prune time settings
([#7343](#7343))
([0adc533](0adc533))

Co-authored-by: krynble <[email protected]>
@janober
Copy link
Member

janober commented Oct 11, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants