Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HTTP Request Node): Decrease default timeout to 5min #7177

Merged
merged 2 commits into from
Sep 20, 2023
Merged

fix(HTTP Request Node): Decrease default timeout to 5min #7177

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
954b946
Decrease default HTTP Request node timeout to 5min
elsmr Sep 14, 2023
782e3a7
Merge branch 'master' into node-746-http-timeout-decrease
elsmr Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/nodes-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ import type {

import {
BINARY_ENCODING,
jsonParse,
NodeApiError,
NodeOperationError,
sleep,
jsonParse,
removeCircularRefs,
sleep,
} from 'n8n-workflow';

import { keysToLowercase } from '@utils/utilities';
Expand Down Expand Up @@ -1152,8 +1152,8 @@ export class HttpRequestV3 implements INodeType {
if (timeout) {
requestOptions.timeout = timeout;
} else {
// set default timeout to 1 hour
requestOptions.timeout = 3600000;
// set default timeout to 5 minutes
requestOptions.timeout = 300_000;
Joffcom marked this conversation as resolved.
Show resolved Hide resolved
}
if (sendQuery && queryParameterArrays) {
Object.assign(requestOptions, {
Expand Down
Loading