Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Use a Set for deletedProperties in AugmentObject (no-changelog) #7131

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Sep 7, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

Copy link
Contributor

@csuermann csuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 88.88% and project coverage change: -0.01% ⚠️

Comparison is base (0a35025) 31.95% compared to head (3113f28) 31.94%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7131      +/-   ##
==========================================
- Coverage   31.95%   31.94%   -0.01%     
==========================================
  Files        3274     3274              
  Lines      197826   197825       -1     
  Branches    21569    21567       -2     
==========================================
- Hits        63212    63203       -9     
- Misses     133558   133566       +8     
  Partials     1056     1056              
Files Changed Coverage Δ
packages/workflow/src/AugmentObject.ts 89.88% <88.88%> (-0.12%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Sep 7, 2023
@cypress
Copy link

cypress bot commented Sep 7, 2023

Passing run #2134 ↗︎

0 238 0 0 Flakiness 0

Details:

🌳 ENG-78 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: 3113f28188
Status: Passed Duration: 07:53 💡
Started: Sep 7, 2023 12:58 PM Ended: Sep 7, 2023 1:06 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

✅ All Cypress E2E specs passed

@netroy netroy merged commit 67aaad1 into master Sep 7, 2023
18 checks passed
@netroy netroy deleted the ENG-78 branch September 7, 2023 13:07
@janober
Copy link
Member

janober commented Sep 14, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants