fix(editor): Tweak hover area of workflow / cred cards #7108
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
n8n team
…area-of-wf-cred-cards
| event.target['className'] === 'el-switch__core' | ||
| this.$refs.cardActions === event.target || | ||
| this.$refs.cardActions?.contains(event.target) || | ||
| event.target?.contains(this.$refs.cardActions) |
There was a problem hiding this comment.
This condition could run into a situation where the click event is cancelled even when the event is triggered by clicking the card itself (the wrapper does contain the card actions).
To avoid this, you could add height: 100% to the cardActions class and then align child items to the center.
There was a problem hiding this comment.
And actually with that in place we can also remove event.target?.contains(this.$refs.cardActions) because the outer most target can only be cardActions which is already checked by this.$refs.cardActions === event.target
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7108 +/- ##
==========================================
+ Coverage 32.00% 32.40% +0.40%
==========================================
Files 3277 3277
Lines 197964 198007 +43
Branches 21593 21651 +58
==========================================
+ Hits 63349 64157 +808
+ Misses 133554 132789 -765
Partials 1061 1061
☔ View full report in Codecov by Sentry. |
2 flaky tests on run #2155 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Output
Screenshots
Video
|
|
28-debug.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Debug > should be able to debug executions |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
✅ All Cypress E2E specs passed |
# [1.7.0](https://github.com/n8n-io/n8n/compare/[email protected]@1.7.0) (2023-09-13) ### Bug Fixes * **Code Node:** Disable WASM to address CVE-2023-37903 ([#7122](#7122)) ([36a8e91](36a8e91)) * **Code Node:** Upgrade vm2 to address CVE-2023-37466 ([#7123](#7123)) ([0a35025](0a35025)) * **core:** Disable Node.js custom inspection to address CVE-2023-37903 ([#7125](#7125)) ([a223734](a223734)) * **editor** Account for nanoid workflow ids for subworkflow execute policy ([#7094](#7094)) ([67092c0](67092c0)) * **editor:** Tweak hover area of workflow / cred cards ([#7108](#7108)) ([217de21](217de21)) * **editor:** Unbind workflow endpoint events in case of workspace reset ([#7129](#7129)) ([c9b7948](c9b7948)) * **editor:** Update git repo url validation regex ([#7151](#7151)) ([e51f173](e51f173)) * **Google Cloud Firestore Node:** Fix empty string interpreted as number ([#7136](#7136)) ([915cfa0](915cfa0)) * **HubSpot Node:** Fix issue with contact lists not working ([#5582](#5582)) ([6e5a4f6](6e5a4f6)) * **Postgres Node:** Fix automatic column mapping ([#7121](#7121)) ([92af131](92af131)) * **Zoho CRM Node:** Fix issue with Sales Order not updating ([#6959](#6959)) ([fd800b6](fd800b6)) ### Features * **core:** Add an option to enable WAL mode for SQLite ([#7118](#7118)) ([1d1a022](1d1a022)) * **core:** Add commands to workers to respond with current state ([#7029](#7029)) ([7b49cf2](7b49cf2)) * **Salesforce Node:** Add fax field to lead option ([#7030](#7030)) ([01f875a](01f875a)) Co-authored-by: netroy <[email protected]>
|
Got released with |
Context
When a user is attempting to interact with a foreground action inside an entity card (workflow, credential, community node, logging destination), they might accidentally open that entity instead of interacting with a foreground action.
For these card components, actions are always placed on right side.
A/C
Area around right "column" of entity cards (workflow, cred, community node, logging destination) should not be a hoverable area (that opens that entity when clicked). This area is roughly highlighted in screen shot below in orange.