ci: Fix versions of all external Github actions (no-changelog) #6984
Conversation
Passing run #1956 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #6984 +/- ##
==========================================
- Coverage 25.13% 25.12% -0.01%
==========================================
Files 3150 3150
Lines 192169 192169
Branches 21177 21172 -5
==========================================
- Hits 48293 48284 -9
- Misses 142894 142903 +9
Partials 982 982 ☔ View full report in Codecov by Sentry. |
|
✅ All Cypress E2E specs passed |
netroy
force-pushed
the
ci-fix
branch
2 times, most recently
from
c85bbf0 to
db389b8
Compare
| - name: Install dependencies | ||
| run: pnpm install --frozen-lockfile |
There was a problem hiding this comment.
Since this is hardlinking to the store, I take it this doesn't add much overhead vs. caching as we did before.
There was a problem hiding this comment.
yeah. this also has the advantage that if there are random 500x from the caching service, CI still works, making the setup a bit more resilient.
| @@ -89,29 +84,28 @@ jobs: | |||
| matrix: | |||
| node-version: [18.x, 20.x] | |||
| steps: | |||
| - uses: actions/checkout@v3 | |||
| - uses: actions/checkout@v3.5.3 | |||
There was a problem hiding this comment.
Specifying versions everywhere like this makes me wish GH actions supported a manifest to centralize this. Very easy to create drift by forgetting to update somewhere.
There was a problem hiding this comment.
after having to update all these files over and over again yesterday, I'm seriously considering creating a DSL to auto-generate these yaml files instead. we have so much duplication 🤦🏽
| with: | ||
| version: 8.6.1 | ||
| version: 8.6.12 |
There was a problem hiding this comment.
Should we pin the pnpm version everywhere else as well?
There was a problem hiding this comment.
this is the only place we need it. elsewhere the version is automatically picked from package.json. I'm going to soon change this workflow to also pick the pnpm version from package.json, so this exception will hopefully go away soon.
| path: | | ||
| /github/home/.cache | ||
| /github/home/.pnpm-store | ||
| ./node_modules | ||
| ./packages |
There was a problem hiding this comment.
Is there a way to monitor GH Actions cache so we can see this coming next time? Or by trimming down cache size this shouldn't be necessary?
There was a problem hiding this comment.
we are down from ~200MB to ~24MB. I think if we start seeing issues at this size, a lot more people will see those issues as well. so, we don't need to worry about this.
| @@ -7,7 +7,7 @@ | |||
| "node": ">=18.10", | |||
| "pnpm": ">=8.6" | |||
| }, | |||
| "packageManager": "[email protected].1", | |||
| "packageManager": "[email protected].12", | |||
There was a problem hiding this comment.
Should we pin also engines.pnpm?
There was a problem hiding this comment.
do you meanengines.pnpm? I'll update in the next PR.
|
✅ All Cypress E2E specs passed |
|
Got released with |
No description provided.