Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix LDAP view info tip color (no-changelog) #6981

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

alexgrozav
Copy link
Member

image

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Aug 21, 2023
@cypress
Copy link

cypress bot commented Aug 21, 2023

Passing run #1946 ↗︎

0 228 0 0 Flakiness 0

Details:

🌳 pay-694-ldap-settings-page-different-font-color 🖥️ browsers:node18.12.0-chro...
Project: n8n Commit: c79eebf89d
Status: Passed Duration: 07:31 💡
Started: Aug 21, 2023 8:03 AM Ended: Aug 21, 2023 8:11 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 9.52% and project coverage change: -0.01% ⚠️

Comparison is base (b6a00fe) 25.13% compared to head (c79eebf) 25.12%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6981      +/-   ##
==========================================
- Coverage   25.13%   25.12%   -0.01%     
==========================================
  Files        3150     3150              
  Lines      192105   192163      +58     
  Branches    21159    21169      +10     
==========================================
- Hits        48288    48284       -4     
- Misses     142835   142897      +62     
  Partials      982      982              
Files Changed Coverage Δ
packages/cli/src/constants.ts 100.00% <ø> (ø)
.../MessageEventBusWriter/MessageEventBusLogWriter.ts 54.36% <0.00%> (-3.92%) ⬇️
...geEventBusWriter/MessageEventBusLogWriterWorker.ts 0.00% <0.00%> (ø)
packages/editor-ui/src/views/SettingsLdapView.vue 0.00% <0.00%> (ø)
...ase/nodes/Google/Sheet/GoogleSheetsTrigger.node.ts 0.00% <0.00%> (ø)
...li/src/eventbus/MessageEventBus/MessageEventBus.ts 47.80% <13.04%> (-4.05%) ⬇️
packages/cli/src/CredentialsHelper.ts 25.35% <22.22%> (-0.14%) ⬇️
packages/cli/src/utils.ts 66.66% <50.00%> (-0.78%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexgrozav alexgrozav merged commit 3126a48 into master Aug 22, 2023
@alexgrozav alexgrozav deleted the pay-694-ldap-settings-page-different-font-color branch August 22, 2023 05:12
@janober
Copy link
Member

janober commented Aug 30, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants