Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Set up OAuth2 cred test #6960

Merged
merged 4 commits into from
Aug 18, 2023
Merged

fix(core): Set up OAuth2 cred test #6960

merged 4 commits into from
Aug 18, 2023

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Aug 17, 2023

@ivov ivov requested a review from a team as a code owner August 17, 2023 14:08
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/cli/src/databases/migrations/**:

  • Requested review from at least two engineers on migration.
  • Avoided irreversible data migrations.
  • Avoided deleting or updating data keys.
  • Wrote 'down' migration if possible.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Aug 17, 2023 •
edited
Loading

Codecov Report

Patch coverage: 27.27% and no project coverage change.

Comparison is base (41db637) 25.14% compared to head (df78c30) 25.14%.
Report is 4 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6960   +/-   ##
=======================================
  Coverage   25.14%   25.14%           
=======================================
  Files        3150     3150           
  Lines      192077   192088   +11     
  Branches    21160    21171   +11     
=======================================
+ Hits        48296    48309   +13     
+ Misses     142799   142797    -2     
  Partials      982      982
Files Changed Coverage Δ
packages/cli/src/constants.ts 100.00% <ø> (ø)
packages/cli/src/CredentialsHelper.ts 25.35% <22.22%> (-0.14%) ⬇️
packages/cli/src/utils.ts 66.66% <50.00%> (-0.78%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Aug 17, 2023
krynble
krynble suggested changes Aug 17, 2023
View reviewed changes
packages/cli/src/CredentialsHelper.ts Outdated Show resolved Hide resolved
packages/cli/src/CredentialsHelper.ts Outdated Show resolved Hide resolved
packages/cli/src/CredentialsHelper.ts Outdated Show resolved Hide resolved
@ivov
Copy link
Contributor Author

ivov commented Aug 17, 2023

Thanks @krynble! Can you please check again?

krynble
krynble approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tested and working fine!

@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress
Copy link

cypress bot commented Aug 18, 2023 •
edited
Loading

1 flaky tests on run #1940 ↗︎

0 228 0 0 Flakiness 1

Details:

🌳 pay-728-bug-cred-test-fails-for-sharee 🖥️ browsers:node18.12.0-chrome107 🤖 ...
Project: n8n Commit: df78c30186
Status: Passed Duration: 07:13 💡
Started: Aug 18, 2023 2:07 PM Ended: Aug 18, 2023 2:14 PM
Flakiness  cypress/e2e/2-credentials.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Credentials > should create a new credential using Add Credential button Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@netroy
Copy link
Member

netroy commented Aug 18, 2023

This branch needs to be rebased to fix the e2e tests.

@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit 4fc69b7 into master Aug 18, 2023
@ivov ivov deleted the pay-728-bug-cred-test-fails-for-sharee branch August 18, 2023 14:18
This was referenced Aug 23, 2023
Closed
Merged
krynble added a commit that referenced this pull request Aug 23, 2023
@github-actions @krynble
🚀 Release 1.4.0 (#7001)
0e89a65 
# [1.4.0](https://github.com/n8n-io/n8n/compare/[email protected]@1.4.0)
(2023-08-23)


### Bug Fixes

* **core:** Add recoveryInProgress flag file
([#6962](#6962))
([7b96820](7b96820))
* **core:** Fix `continueOnFail` for expression error in Set
([#6939](#6939))
([d4fac05](d4fac05))
* **core:** Fix `import:workflow` command
([#6996](#6996))
([8c38d85](8c38d85))
* **core:** Replace throw with warning when deactivating a non-active
workflow ([#6969](#6969))
([b6a00fe](b6a00fe))
* **core:** Set up OAuth2 cred test
([#6960](#6960))
([4fc69b7](4fc69b7))
* **editor:** Do not flag dynamic load options issue on expression
([#6932](#6932))
([60a1ef0](60a1ef0))
* **editor:** Ensure community node install button tracks user agreement
([#6976](#6976))
([0ddfc73](0ddfc73))
* **editor:** Fix parsing for single quoted resolvables
([#6982](#6982))
([f32e993](f32e993))
* **editor:** Fix Remove all fields not removing values in resource
mapper ([#6940](#6940))
([e6cff3f](e6cff3f))
* **editor:** Prevent Code node linter from erroring on `null` parse
([#6934](#6934))
([40d3a29](40d3a29))
* **Google Sheets Node:** Fix short sheet name interpreted as range
([#6989](#6989))
([00268a0](00268a0))
* **Google Sheets Trigger Node:** Support sheet names with non-latin
characters ([#6970](#6970))
([052dd7c](052dd7c))
* **GraphQL Node:** Improve error handling
([#6955](#6955))
([41db637](41db637))
* **Mautic Node:** Fix issue with owner not being set correctly
([#6991](#6991))
([64b950f](64b950f))
* **Salesforce Node:** Fix Account update owner operation
([#6958](#6958))
([9b27878](9b27878))
* **Shopify Node:** Fix pagination when using options
([#6972](#6972))
([475d9c9](475d9c9))
* **Webhook Node:** Backward compatible form-data parsing for non-array
fields ([#6967](#6967))
([9455bcf](9455bcf))


### Features

* **core:** Add a warning to error workflows that cannot be started due
to permission or settings
([#6961](#6961))
([67b88f7](67b88f7))
* **core:** Add support for ready hooks, and credentials overwrite
endpoint in workers ([#6954](#6954))
([8f8a1de](8f8a1de))
* **editor:** Show banner for non-production licenses
([#6943](#6943))
([413570c](413570c))
* Remove PostHog event calls
([#6915](#6915))
([270946a](270946a))
* **Send Email Node:** Add support for sending text and html email
simultaneously ([#6978](#6978))
([3860d41](3860d41))

Co-authored-by: krynble <[email protected]>
@janober
Copy link
Member

janober commented Aug 30, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flipswitchingmonkey flipswitchingmonkey flipswitchingmonkey approved these changes

@krynble krynble krynble approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ivov @netroy @janober @krynble @flipswitchingmonkey