Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): Remove sign-in type from user dropdowns #6926

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Aug 14, 2023

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/design-system/**/*.vue:

  • Used design system tokens (colors, spacings...) where possible.
  • Updated Storybook with new component or updated functionality.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (4e4a3cf) 24.84% compared to head (3219a81) 24.84%.
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6926      +/-   ##
==========================================
- Coverage   24.84%   24.84%   -0.01%     
==========================================
  Files        3144     3144              
  Lines      191232   191216      -16     
  Branches    21087    21088       +1     
==========================================
- Hits        47519    47505      -14     
+ Misses     142735   142733       -2     
  Partials      978      978              
Files Changed Coverage Δ
...ign-system/src/components/N8nUserInfo/UserInfo.vue 95.83% <ø> (-0.50%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Aug 14, 2023
@cypress
Copy link

cypress bot commented Aug 17, 2023

1 flaky tests on run #1896 ↗︎

0 221 0 0 Flakiness 1

Details:

🌳 pay-434-remove-sign-in-type-from-user-dropdowns 🖥️ browsers:node18.12.0-chro...
Project: n8n Commit: 3219a81a96
Status: Passed Duration: 06:36 💡
Started: Aug 17, 2023 8:21 AM Ended: Aug 17, 2023 8:28 AM
Flakiness  cypress/e2e/2-credentials.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Credentials > should create a new credential using Add Credential button Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit 914dd1f into master Aug 17, 2023
@ivov ivov deleted the pay-434-remove-sign-in-type-from-user-dropdowns branch August 17, 2023 08:29
@janober
Copy link
Member

janober commented Aug 30, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants