fix: Add only necessary information to executions (no-changelog) #6916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
core
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #6916 +/- ##
==========================================
- Coverage 24.85% 24.85% -0.01%
==========================================
Files 3144 3144
Lines 191241 191241
Branches 21090 21089 -1
==========================================
- Hits 47527 47526 -1
- Misses 142736 142737 +1
Partials 978 978
☔ View full report in Codecov by Sentry. |
ivov
previously approved these changes
Aug 11, 2023
|
Related to #6901 |
1 flaky tests on run #1855 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
✅ All Cypress E2E specs passed |
ivov
approved these changes
Aug 11, 2023
|
✅ All Cypress E2E specs passed |
netroy
pushed a commit
that referenced
this pull request
Aug 14, 2023
* fix: Add only necessary information to executions * Fix lint * fix: lint issue --------- Co-authored-by: Iván Ovejero <[email protected]>
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically):
The goal of this PR is that we need
sharedWith,ownedByandusedCredentialsin executions to properly display the data, but we cannot override the execution's version of the workflow with the one currently in db as they might differ. This PR fetches only the necessary attributes.