Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix missing and invalid documentation urls for various credentials (no-changelog) #6893

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Aug 9, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@netroy
Copy link
Member Author

netroy commented Aug 9, 2023

Test run

Copy link
Contributor

@michael-radency michael-radency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Aug 9, 2023
@cypress
Copy link

cypress bot commented Aug 9, 2023

Passing run #1832 ↗︎

0 221 0 0 Flakiness 0

Details:

🌳 fix-documentation-urls 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: c2186ef6bb
Status: Passed Duration: 07:26 💡
Started: Aug 9, 2023 1:03 PM Ended: Aug 9, 2023 1:11 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

✅ All Cypress E2E specs passed

@netroy netroy merged commit d396935 into master Aug 9, 2023
19 checks passed
@netroy netroy deleted the fix-documentation-urls branch August 9, 2023 13:16
netroy added a commit that referenced this pull request Aug 9, 2023
@janober
Copy link
Member

janober commented Aug 9, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants