Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Debug execution #6834

Merged
merged 71 commits into from
Aug 25, 2023
Merged

feat(editor): Debug execution #6834

merged 71 commits into from
Aug 25, 2023

Conversation

cstuncsik
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Files matching packages/editor-ui/src/mixins/**:

  • Avoided adding new mixins (use composables instead). Only removed code from here.

Files matching packages/editor-ui/src/views/NodeView.vue:

  • Avoided adding code here. Only refactored to make it smaller.

Files matching cypress/e2e/**:

  • Avoided chaining commands more than two or three times (to avoid flakiness because only last one will be retried).
  • Spoofed endpoints that are not critical for the test (to avoid flakiness).
  • Picked most efficient path to start the test (for example skipped account setup and starting at /workflow/new for a canvas test).
  • Avoided adding waits on time (use request intercepts instead).
  • Ensured each spec does not depend on any another spec to pass.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 47.18% and project coverage change: +6.74% 🎉

Comparison is base (72f65dc) 25.22% compared to head (646b277) 31.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6834      +/-   ##
==========================================
+ Coverage   25.22%   31.96%   +6.74%     
==========================================
  Files        3160     3162       +2     
  Lines      193299   193596     +297     
  Branches    21236    21184      -52     
==========================================
+ Hits        48754    61889   +13135     
+ Misses     143565   130727   -12838     
  Partials      980      980              
Files Changed Coverage Δ
...ges/editor-ui/src/components/DebugPaywallModal.vue 0.00% <0.00%> (ø)
...editor-ui/src/components/MainHeader/MainHeader.vue 44.97% <0.00%> (+44.97%) ⬆️
packages/editor-ui/src/components/Modals.vue 0.00% <0.00%> (ø)
packages/editor-ui/src/views/NodeView.vue 16.84% <7.69%> (+16.84%) ⬆️
packages/editor-ui/src/composables/useMessage.ts 50.00% <33.33%> (ø)
...editor-ui/src/composables/useExecutionDebugging.ts 33.56% <33.56%> (ø)
packages/editor-ui/src/stores/ui.store.ts 57.23% <75.00%> (+2.86%) ⬆️
...src/components/ExecutionsView/ExecutionPreview.vue 81.84% <91.66%> (+81.84%) ⬆️
packages/editor-ui/src/router.ts 88.90% <97.91%> (+88.90%) ⬆️
packages/editor-ui/src/Interface.ts 100.00% <100.00%> (ø)
... and 4 more

... and 97 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstuncsik cstuncsik marked this pull request as ready for review August 3, 2023 13:25
@cstuncsik cstuncsik requested a review from alexgrozav August 3, 2023 13:27
@cstuncsik cstuncsik changed the title feat(editor): Debug execution feat(editor): Debug execution (no-changelog) Aug 4, 2023
@cstuncsik cstuncsik changed the title feat(editor): Debug execution (no-changelog) feat(editor): Debug execution [WIP] (no-changelog) Aug 4, 2023
@cstuncsik cstuncsik changed the title feat(editor): Debug execution [WIP] (no-changelog) feat(editor): Debug execution Aug 18, 2023
Copy link
Member

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking and working well. One small change I'd like to request regarding the HTML string you're rendering.

@cstuncsik cstuncsik requested a review from alexgrozav August 21, 2023 19:30
alexgrozav
alexgrozav previously approved these changes Aug 22, 2023
@cypress
Copy link

cypress bot commented Aug 22, 2023

1 flaky tests on run #1997 ↗︎

0 232 0 0 Flakiness 1

Details:

🌳 pay-668-debug-mode 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project: n8n Commit: 646b27782d
Status: Passed Duration: 08:59 💡
Started: Aug 25, 2023 7:18 AM Ended: Aug 25, 2023 7:27 AM
Flakiness  cypress/e2e/27-two-factor-authentication.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Two-factor authentication > Should be able to login with MFA token Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@krynble krynble merged commit c833078 into master Aug 25, 2023
@krynble krynble deleted the pay-668-debug-mode branch August 25, 2023 07:39
@github-actions github-actions bot mentioned this pull request Aug 31, 2023
netroy added a commit that referenced this pull request Aug 31, 2023
# [1.5.0](https://github.com/n8n-io/n8n/compare/[email protected]@1.5.0)
(2023-08-31)


### Bug Fixes

* **Agile CRM Node:** Fix issue with company address not working
([#6997](#6997))
([2f81652](2f81652))
* **Code Node:** Switch over to vm2 fork
([#7018](#7018))
([dfe0fa6](dfe0fa6))
* **core:** Invalid NODES_INCLUDE should not crash the app
([#7038](#7038))
([04e3178](04e3178)),
closes [#6683](#6683)
* **core:** Setup websocket keep-live messages
([#6866](#6866))
([8bdb07d](8bdb07d)),
closes [#6757](#6757)
* **core:** Throw `NodeSSLError` only for nodes that allow ignoring SSL
issues ([#6928](#6928))
([a01c3fb](a01c3fb))
* **Date & Time Node:** Dont parse date if it's not set (null or
undefined) ([#7050](#7050))
([d72f79f](d72f79f))
* **editor:** Fix sending of Ask AI tracking events
([#7002](#7002))
([fb05afa](fb05afa))
* **Microsoft Excel 365 Node:** Support for more extensions in workbook
rlc ([#7020](#7020))
([d6e1cf2](d6e1cf2))
* **MongoDB Node:** Stringify response ObjectIDs
([#6990](#6990))
([9ca990b](9ca990b))
* **MongoDB Node:** Upgrade mongodb package to address CVE-2021-32050
([#7054](#7054))
([d3f6356](d3f6356))
* **Postgres Node:** Empty return data fix for Postgres and MySQL
([#7016](#7016))
([176ccd6](176ccd6))
* **Webhook Node:** Fix URL params for webhooks
([#6986](#6986))
([596b569](596b569))


### Features

* **core:** External Secrets storage for credentials
([#6477](#6477))
([ed927d3](ed927d3))
* **core:** Add MFA ([#4767](#4767))
([2b7ba6f](2b7ba6f))
* **core:** Add filtering, selection and pagination to users
([#6994](#6994))
([b716241](b716241))
* **editor:** Debug executions in the editor
([#6834](#6834))
([c833078](c833078))
* **RSS Read Node:** Add support for self signed certificates
([#7039](#7039))
([3b9f0fe](3b9f0fe))

Co-authored-by: netroy <[email protected]>
@janober
Copy link
Member

janober commented Aug 31, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants