Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(core): Cache roles #6803

Merged
merged 32 commits into from
Aug 3, 2023
Merged

perf(core): Cache roles #6803

merged 32 commits into from
Aug 3, 2023

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jul 31, 2023

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 67.74% and no project coverage change.

Comparison is base (659ca26) 24.76% compared to head (ed1cdc8) 24.77%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6803   +/-   ##
=======================================
  Coverage   24.76%   24.77%           
=======================================
  Files        3131     3130    -1     
  Lines      190809   190825   +16     
  Branches    21013    21020    +7     
=======================================
+ Hits        47262    47269    +7     
- Misses     142591   142598    +7     
- Partials      956      958    +2     
Files Changed Coverage Δ
packages/cli/src/Server.ts 0.00% <0.00%> (ø)
packages/cli/src/commands/import/credentials.ts 0.00% <0.00%> (ø)
packages/cli/src/controllers/e2e.controller.ts 0.00% <0.00%> (ø)
...ts/sourceControl/sourceControlImport.service.ee.ts 9.31% <12.50%> (+0.36%) ⬆️
packages/cli/src/commands/user-management/reset.ts 27.77% <25.00%> (ø)
packages/cli/src/InternalHooks.ts 5.75% <33.33%> (ø)
...ges/cli/src/UserManagement/UserManagementHelper.ts 79.34% <50.00%> (+0.18%) ⬆️
packages/cli/src/sso/saml/samlHelpers.ts 38.38% <50.00%> (ø)
packages/cli/src/WorkflowHelpers.ts 49.18% <60.00%> (+0.27%) ⬆️
packages/cli/src/services/ownership.service.ts 72.22% <75.00%> (+1.63%) ⬆️
... and 15 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.vscode/settings.default.json Outdated Show resolved Hide resolved
@ivov ivov marked this pull request as ready for review July 31, 2023 14:18
krynble
krynble previously approved these changes Aug 1, 2023
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Code looks nice and functionality too. Loved it 💯

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress
Copy link

cypress bot commented Aug 1, 2023

1 flaky tests on run #1759 ↗︎

0 221 0 0 Flakiness 1

Details:

🌳 pay-666-cache-roles 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project: n8n Commit: ed1cdc8661
Status: Passed Duration: 07:06 💡
Started: Aug 2, 2023 4:33 PM Ended: Aug 2, 2023 4:40 PM
Flakiness  cypress/e2e/2-credentials.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Credentials > should create a new credential using Add Credential button Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@ivov ivov requested a review from netroy August 1, 2023 09:58
netroy
netroy previously approved these changes Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

3 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@netroy
Copy link
Member

netroy commented Aug 2, 2023

@ivov are the e2e tests passing for you locally on this branch?

@ivov
Copy link
Contributor Author

ivov commented Aug 2, 2023

@ivov are the e2e tests passing for you locally on this branch?

e2e tests keep failing randomly elsewhere so I've been defaulting to rerunning them without a closer look, I'll check locally.

@ivov ivov dismissed stale reviews from flipswitchingmonkey and netroy via 339ecbf August 2, 2023 12:47
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

✅ All Cypress E2E specs passed

@ivov ivov merged commit e4f0418 into master Aug 3, 2023
@ivov ivov deleted the pay-666-cache-roles branch August 3, 2023 06:58
@github-actions github-actions bot mentioned this pull request Aug 9, 2023
@janober
Copy link
Member

janober commented Aug 9, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants