-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(core): Cache roles #6803
perf(core): Cache roles #6803
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6803 +/- ##
=======================================
Coverage 24.76% 24.77%
=======================================
Files 3131 3130 -1
Lines 190809 190825 +16
Branches 21013 21020 +7
=======================================
+ Hits 47262 47269 +7
- Misses 142591 142598 +7
- Partials 956 958 +2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Code looks nice and functionality too. Loved it 💯
|
1 flaky tests on run #1759 ↗︎
Details:
cypress/e2e/2-credentials.cy.ts • 1 flaky test
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|
|
|
3 similar comments
|
|
|
@ivov are the e2e tests passing for you locally on this branch? |
e2e tests keep failing randomly elsewhere so I've been defaulting to rerunning them without a closer look, I'll check locally. |
✅ All Cypress E2E specs passed |
Got released with |
https://linear.app/n8n/issue/PAY-666/cache-roles-queries
Latest e2e run: https://github.com/n8n-io/n8n/actions/runs/5740482744