Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GitLab Trigger Node): Fix trigger activation 404 error #6711

Merged
merged 2 commits into from
Jul 21, 2023
Merged

fix(GitLab Trigger Node): Fix trigger activation 404 error #6711

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86572fc
fix webhook checkExists not deleting static data
maspio Jul 20, 2023
b4a53de
improve webhook checkExists not deleting static data
maspio Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/nodes-base/nodes/Gitlab/GitlabTrigger.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ export class GitlabTrigger implements INodeType {
try {
await gitlabApiRequest.call(this, 'GET', endpoint, {});
} catch (error) {
if (error.cause.httpCode === '404') {
if (error.description.includes('404')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add this as OR
if (error.cause.httpCode === '404' || error.description.includes('404')) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it accordingly

// Webhook does not exist
delete webhookData.webhookId;
delete webhookData.webhookEvents;
Expand Down