Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): Update endpoint to retrieve limits (no-changelog) #6539

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Jun 26, 2023

We are going to deprecate the /limits endpoints in the hooks in favor of /cloud/limits. This PRs updates the endpoint, to start using the new one.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@RicardoE105 RicardoE105 changed the title update endpoint to retrieve limits chore(editor): Update endpoint to retrieve limits Jun 26, 2023
@RicardoE105 RicardoE105 changed the title chore(editor): Update endpoint to retrieve limits refactor(editor): Update endpoint to retrieve limits Jun 26, 2023
@RicardoE105 RicardoE105 changed the title refactor(editor): Update endpoint to retrieve limits refactor(editor): Update endpoint to retrieve limits (no-changelog) Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (665710f) 28.72% compared to head (4a3271b) 28.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6539      +/-   ##
==========================================
- Coverage   28.72%   28.65%   -0.08%     
==========================================
  Files        3000     3000              
  Lines      186310   186310              
  Branches    20604    20601       -3     
==========================================
- Hits        53521    53379     -142     
- Misses     131979   132121     +142     
  Partials      810      810              
Impacted Files Coverage Δ
packages/editor-ui/src/api/cloudPlans.ts 30.76% <0.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jun 26, 2023
@cypress
Copy link

cypress bot commented Jun 26, 2023

2 flaky tests on run #1323 ↗︎

0 227 0 0 Flakiness 2

Details:

🌳 feature/update-limits-endpoint 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE...
Project: n8n Commit: 4a3271ba87
Status: Passed Duration: 07:26 💡
Started: Jun 26, 2023 5:05 AM Ended: Jun 26, 2023 5:13 AM
Flakiness  20-workflow-executions.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Current Workflow Executions > should render executions tab correctly Output Screenshots Video
Flakiness  15-scheduler-node.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Schedule Trigger node > should execute once per second when activated Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@RicardoE105 RicardoE105 merged commit e43924d into master Jun 27, 2023
@RicardoE105 RicardoE105 deleted the feature/update-limits-endpoint branch June 27, 2023 02:08
@janober
Copy link
Member

janober commented Jul 5, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants