Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix docs urls (no-changelog) #6433

Merged
merged 1 commit into from
Jun 14, 2023
Merged

ci: Fix docs urls (no-changelog) #6433

merged 1 commit into from
Jun 14, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Jun 14, 2023

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@netroy netroy force-pushed the fix-docs-urls branch 2 times, most recently from 4e0f691 to f25c59a Compare June 14, 2023 14:54
@netroy netroy changed the title ci: Fix docs urls for LoneScaleApi.credentials and Ldap.node (no-changelog) ci: Fix docs urls (no-changelog) Jun 14, 2023
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Jun 14, 2023
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (90fd926) 28.41% compared to head (1dd3a52) 28.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6433      +/-   ##
==========================================
- Coverage   28.41%   28.33%   -0.08%     
==========================================
  Files        2983     2983              
  Lines      185066   185068       +2     
  Branches    20365    20363       -2     
==========================================
- Hits        52582    52440     -142     
- Misses     131696   131840     +144     
  Partials      788      788              
Impacted Files Coverage Δ
...ackages/nodes-base/credentials/Ldap.credentials.ts 0.00% <0.00%> (ø)
...nodes-base/credentials/LoneScaleApi.credentials.ts 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress
Copy link

cypress bot commented Jun 14, 2023

Passing run #1195 ↗︎

0 227 0 0 Flakiness 0

Details:

🌳 fix-docs-urls 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: 1dd3a52df6
Status: Passed Duration: 07:17 💡
Started: Jun 14, 2023 5:42 PM Ended: Jun 14, 2023 5:49 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 004d38d into master Jun 14, 2023
@netroy netroy deleted the fix-docs-urls branch June 14, 2023 19:48
netroy added a commit that referenced this pull request Jun 19, 2023
@janober
Copy link
Member

janober commented Jun 22, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants