Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix randomly failing scheduler node e2e tests (no-changelog) #6430

Merged

Conversation

alexgrozav
Copy link
Member

image

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching cypress/e2e/**:

  • Avoided chaining commands more than two or three times (to avoid flakiness because only last one will be retried).
  • Spoofed endpoints that are not critical for the test (to avoid flakiness).
  • Picked most efficient path to start the test (for example skipped account setup and starting at /workflow/new for a canvas test).
  • Avoided adding waits on time (use request intercepts instead).
  • Ensured each spec does not depend on any another spec to pass.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jun 14, 2023
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (10bb5be) 28.41% compared to head (7d7988f) 28.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6430      +/-   ##
==========================================
- Coverage   28.41%   28.34%   -0.08%     
==========================================
  Files        2983     2983              
  Lines      185066   185066              
  Branches    20367    20365       -2     
==========================================
- Hits        52582    52451     -131     
- Misses     131696   131827     +131     
  Partials      788      788              

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexgrozav alexgrozav requested review from netroy and OlegIvaniv June 15, 2023 08:58
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@cypress
Copy link

cypress bot commented Jun 15, 2023

Passing run #1206 ↗︎

0 227 0 0 Flakiness 0

Details:

🌳 pay-533-fix-scheduler-node-randomly-failing-e2e-test 🖥️ browsers:node18.12.0...
Project: n8n Commit: 7d7988fcfc
Status: Passed Duration: 06:52 💡
Started: Jun 15, 2023 11:29 AM Ended: Jun 15, 2023 11:36 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@alexgrozav alexgrozav merged commit c2afed4 into master Jun 15, 2023
@alexgrozav alexgrozav deleted the pay-533-fix-scheduler-node-randomly-failing-e2e-test branch June 15, 2023 11:40
netroy pushed a commit that referenced this pull request Jun 19, 2023
)

* fix: fix randomly failing scheduler node e2e tests (no-changelog)

* chore: rename variable name

* fix: update all cy.request calls to use backend base url

* fix: add back mistkenly removed workflowId code

* fix: remove unnecessary .then

* fix: update how workflowId is retrieved
@janober
Copy link
Member

janober commented Jun 22, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants