Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Google service account remove duplicated functions (no-changelog) #6368

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

michael-radency
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@michael-radency michael-radency added n8n team Authored by the n8n team tech debt labels Jun 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage: 21.05% and project coverage change: -0.08 ⚠️

Comparison is base (968b733) 28.33% compared to head (c0ef659) 28.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6368      +/-   ##
==========================================
- Coverage   28.33%   28.25%   -0.08%     
==========================================
  Files        2982     2983       +1     
  Lines      185187   185102      -85     
  Branches    20304    20299       -5     
==========================================
- Hits        52464    52306     -158     
- Misses     131936   132009      +73     
  Partials      787      787              
Impacted Files Coverage Δ
.../nodes-base/nodes/Google/Books/GenericFunctions.ts 0.00% <0.00%> (ø)
...s/nodes-base/nodes/Google/Chat/GenericFunctions.ts 0.00% <0.00%> (ø)
...s/nodes-base/nodes/Google/Docs/GenericFunctions.ts 0.00% <0.00%> (ø)
.../nodes-base/nodes/Google/Drive/GenericFunctions.ts 0.00% <0.00%> (ø)
...des-base/nodes/Google/Sheet/v1/GenericFunctions.ts 0.00% <0.00%> (ø)
...-base/nodes/Google/Sheet/v1/GoogleSheetsV1.node.ts 0.00% <0.00%> (ø)
...se/nodes/Google/Sheet/v2/methods/credentialTest.ts 0.00% <0.00%> (ø)
...nodes-base/nodes/Google/Slides/GenericFunctions.ts 0.00% <0.00%> (ø)
...es-base/nodes/Google/Translate/GenericFunctions.ts 0.00% <0.00%> (ø)
...ckages/nodes-base/nodes/Google/GenericFunctions.ts 36.36% <36.36%> (ø)
... and 4 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cypress
Copy link

cypress bot commented Jun 6, 2023

1 flaky tests on run #1126 ↗︎

0 228 0 0 Flakiness 1

Details:

🌳 node-466-refactor-google-service-account 🖥️ browsers:node18.12.0-chrome107 ?...
Project: n8n Commit: c0ef659009
Status: Passed Duration: 07:04 💡
Started: Jun 6, 2023 4:00 PM Ended: Jun 6, 2023 4:08 PM
Flakiness  cypress/e2e/7-workflow-actions.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Workflow Actions > should not be able to delete unsaved workflow Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 05c4229 into master Jun 6, 2023
@michael-radency michael-radency deleted the node-466-refactor-google-service-account branch June 6, 2023 16:19
MiloradFilipovic added a commit that referenced this pull request Jun 13, 2023
* master:
  test(editor): Unit test Version control frontend components (#6408)
  fix: Fist name to First Name in certain nodes (no-changelog) (#6404)
  fix(core): Allow all executions to be stopped (#6386)
  fix(core): RMC boolean value fix (#6397)
  fix(editor): Remove root level tag selector from css module to avoid making it a global style (#6392)
  fix(Ldap Node): Add DN field to update operation (#6371)
  feat: New trigger PostgreSQL  (#5495)
  build: Update pnpm lock file (no-changelog) (#6395)
  fix(Date & Time Node): Reset responseData at end of loop (#6385)
  refactor(core): Google service account remove duplicated functions (no-changelog) (#6368)
  refactor(LoneScale List Node)!: Rename to LoneScale (#6337)
  fix(editor): Update version control setup CTA tooltip (#6393)
  ci: Fix build (no-changelog) (#6391)
  fix(editor): Add button to refresh branches (#6387)
  fix(editor): Add Set up version control CTA (#6356)
  fix(editor): Remove explicit parameter name scanning for code editors (#6390)
  ci: Fix build (no-changelog) (#6379)
  fix(editor): Adding branch color (#6380)
  refactor(editor): Remove user activation modal (no-changelog) (#6361)
  feat(editor): Change upgrade CTA on community editions (no-changelog) (#6317)
@janober
Copy link
Member

janober commented Jun 14, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants