Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Set up Turborepo cache for GitHub actions runner (no-changelog) #6335

Merged
merged 2 commits into from
Jun 2, 2023
Merged

ci: Set up Turborepo cache for GitHub actions runner (no-changelog) #6335

merged 2 commits into from
Jun 2, 2023

Conversation

ivov
Copy link
Contributor

@ivov ivov commented May 30, 2023

No description provided.

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.63 🎉

Comparison is base (8f0ff46) 27.65% compared to head (a8e8347) 28.29%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6335      +/-   ##
==========================================
+ Coverage   27.65%   28.29%   +0.63%     
==========================================
  Files        2958     2966       +8     
  Lines      181379   183332    +1953     
  Branches    19723    20129     +406     
==========================================
+ Hits        50165    51875    +1710     
- Misses     130467   130685     +218     
- Partials      747      772      +25

see 72 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

netroy
netroy previously approved these changes May 30, 2023
View reviewed changes
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

netroy
netroy reviewed May 30, 2023
View reviewed changes
Copy link
Member

@netroy netroy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we set this up for the test task as well?

@ivov
Copy link
Contributor Author

ivov commented May 30, 2023

can we set this up for the test task as well?

To clarify, do you mean this test task? I'd expect the tasks that run after TR is configured on the runner will check the cache?

@netroy
Copy link
Member

netroy commented May 31, 2023

I meant any step in any of the workflows that executes pnpm test or pnpm build should use this cache.

@ivov
Copy link
Contributor Author

ivov commented May 31, 2023

I originally did it only for PR checks because this action is experimental, but I added others now if you're okay with it. For unit-test in ci-pull-requests.yml from what I understand the cache should available, as it is configured during the first job install.

@ivov ivov requested a review from netroy June 2, 2023 06:45
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

✅ All Cypress E2E specs passed

@ivov ivov merged commit 9dfc110 into master Jun 2, 2023
@ivov ivov deleted the set-up-turborepo-cache-for-github-actions-runner branch June 2, 2023 08:57
netroy added a commit that referenced this pull request Jun 2, 2023
@netroy
Revert "ci: Set up Turborepo cache for GitHub actions runner (no-chan…
683dae3 
…gelog) (#6335)"

This reverts commit 9dfc110.
@netroy netroy mentioned this pull request Jun 2, 2023
Merged
ivov pushed a commit that referenced this pull request Jun 2, 2023
@netroy
ci: Revert "Set up Turborepo cache for GitHub actions runner" (#6364)…
e1aa654 
… (no-changelog)

Revert "ci: Set up Turborepo cache for GitHub actions runner (no-changelog) (#6335)"

This reverts commit 9dfc110.
MiloradFilipovic added a commit that referenced this pull request Jun 2, 2023
@MiloradFilipovic
Merge branch 'master' into sql-editor-support-expressions
b66295f 
* master:
  fix(editor): Fix hard-coded parameter names for code editors (#6372)
  ci: Add support for Node.js 18 (#5793)
  ci: Update the release process for v1 release (#6366)
  refactor: Add deprecation notice for UM disabled mode (#6367)
  feat(editor): Make WF name a link on /executions (#6354)
  ci: Revert "Set up Turborepo cache for GitHub actions runner" (#6364) (no-changelog)
  fix(editor): Add secondary icon to menu items (#6351)
  fix(editor): Pin all data regardless of pagination (#6346)
  feat(Crypto Node): Add support for hash and hmac on binary data (#6359)
  ci: Set up Turborepo cache for GitHub actions runner (no-changelog) (#6335)

# Conflicts:
#	packages/editor-ui/src/components/ParameterInput.vue
@janober
Copy link
Member

janober commented Jun 14, 2023

Got released with [email protected]

@ivov ivov mentioned this pull request Nov 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivov @netroy @janober