feat(Item Lists Node): Improvements #6190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mprovements-item-lists
michael-radency
added
node/improvement
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
michael-radency
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6190 +/- ##
==========================================
- Coverage 28.37% 28.30% -0.08%
==========================================
Files 2991 2991
Lines 185889 185902 +13
Branches 20474 20477 +3
==========================================
- Hits 52742 52613 -129
- Misses 132355 132496 +141
- Partials 792 793 +1
☔ View full report in Codecov by Sentry. |
…mprovements-item-lists
…mprovements-item-lists
maspio
approved these changes
Jun 15, 2023
|
|
3 flaky tests on run #1210 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Webhook Trigger node > should listen for a GET request |
Output
Screenshots
Video
|
|
9-expression-editor-modal.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Expression editor modal > should resolve array resolvables |
Output
Screenshots
Video
|
|
20-workflow-executions.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Current Workflow Executions > should render executions tab correctly |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
…mprovements-item-lists
maspio
approved these changes
Jun 15, 2023
|
✅ All Cypress E2E specs passed |
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically):
https://linear.app/n8n/issue/NODE-85/item-list-helper-improvements