fix(editor): Show error in RLC if credentials are not set #6108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
n8n team
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #6108 +/- ##
=======================================
Coverage 19.19% 19.19%
=======================================
Files 2589 2589
Lines 116890 116890
Branches 18339 18339
=======================================
Hits 22439 22439
Misses 93806 93806
Partials 645 645 ☔ View full report in Codecov by Sentry. |
cstuncsik
reviewed
Apr 27, 2023
| <a v-if="credentialsNotSet" @click="createNewCredential">{{ | ||
| $locale.baseText('resourceLocator.mode.list.error.description.part2.noCredentials') | ||
| }}</a> | ||
| <a v-else-if="hasCredential" @click="openCredential">{{ |
There was a problem hiding this comment.
In order to not repeat template parts you could use the condition inside a common click handler, even inline
Suggested change
| <a v-else-if="hasCredential" @click="openCredential">{{ | |
| <a @click="() => hasCredential ? openCredential() : createNewCredential()">{{ |
Actually this doesn't look much nicer but at least fewer lines. I leave it up to you
cstuncsik
approved these changes
Apr 27, 2023
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Apr 27, 2023
* master: fix(editor): Remove pagination from binary data output (#6093) fix(editor): Show error in RLC if credentials are not set (#6108) fix(editor): Loading state for executions tab (#6100) ci: Additionally checkout PR head for e2e tests (no-changelog) (#6105) fix(core): Skip auth for controllers/routes that don't use the `Authorized` decorator, or use `Authorized('none')` (#6106) fix(editor): Disable changing of email and pw when SAML login enabled (#6104) fix(HTTP Request Node): Always lowercase headers fix(Compression Node): Fix issue with decompression failing with uppercase extensions (#6098) fix(Mattermost Node): Fix base url trailing slash error (#6097) feat(Item Lists Node): Split out items work on objects as well as arrays
netroy
pushed a commit
that referenced
this pull request
May 2, 2023
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically):