ci: Enforce no unused imports (no-changelog) #6073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
netroy
previously approved these changes
Apr 24, 2023
netroy
reviewed
Apr 24, 2023
| /** | ||
| * https://github.com/sweepline/eslint-plugin-unused-imports/blob/master/docs/rules/no-unused-imports.md | ||
| */ | ||
| 'unused-imports/no-unused-imports': 'error', |
There was a problem hiding this comment.
should we make this a warning during development ?
n8n-assistant
bot
added
core
|
✅ All Cypress E2E specs passed |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6073 +/- ##
==========================================
- Coverage 18.63% 18.61% -0.02%
==========================================
Files 2584 2584
Lines 116415 116410 -5
Branches 18180 18183 +3
==========================================
- Hits 21689 21673 -16
- Misses 94092 94101 +9
- Partials 634 636 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Looks good, as author I cannot approve though. |
netroy
approved these changes
Apr 25, 2023
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Apr 26, 2023
* master: fix(core): Serialize dates and regexps when reading from augmented objects (#6086) feat(editor): Enhance Node Creator actions view (#5954) fix(editor): Make the frontend work again when `NODE_FUNCTION_ALLOW_EXTERNAL` is set (no-changelog) (#6058) feat(editor): Add SQL editor support (#5517) refactor(editor): Track advanced filter custom data usage (#6084) refactor(editor): Replace monaco-editor/prismjs with CodeMirror (#5983) ci: Enforce no unused imports (no-changelog) (#6073) # Conflicts: # packages/editor-ui/src/components/ParameterInput.vue # packages/editor-ui/src/stores/nodeTypes.ts
MiloradFilipovic
added a commit
that referenced
this pull request
Apr 26, 2023
…rce-mapper-ui-P2 * feature/resource-mapping-component: fix(core): Serialize dates and regexps when reading from augmented objects (#6086) feat(editor): Enhance Node Creator actions view (#5954) fix(editor): Make the frontend work again when `NODE_FUNCTION_ALLOW_EXTERNAL` is set (no-changelog) (#6058) feat(editor): Add SQL editor support (#5517) refactor(editor): Track advanced filter custom data usage (#6084) refactor(editor): Replace monaco-editor/prismjs with CodeMirror (#5983) ci: Enforce no unused imports (no-changelog) (#6073) # Conflicts: # packages/editor-ui/src/stores/nodeTypes.ts
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #6060, to address the unused-imports comments in this review.
The combine-imports comments are covered by #6072.