Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Replace client-oauth2 with an in-repo package #6056

Merged
merged 12 commits into from
May 16, 2023
Merged

feat(core): Replace client-oauth2 with an in-repo package #6056

merged 12 commits into from
May 16, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Apr 21, 2023

@netroy netroy requested a review from maspio April 21, 2023 12:06
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Apr 21, 2023
@netroy netroy force-pushed the n8n-3921-client-oauth2 branch from fd05c94 to 190daf0 Compare April 21, 2023 13:10
@netroy netroy force-pushed the n8n-3921-client-oauth2 branch from 66288e9 to ef0e200 Compare May 2, 2023 23:56
@netroy netroy force-pushed the n8n-3921-client-oauth2 branch from ef0e200 to d65902e Compare May 10, 2023 20:15
@netroy netroy marked this pull request as ready for review May 10, 2023 20:15
@netroy netroy force-pushed the n8n-3921-client-oauth2 branch from d65902e to 33bf705 Compare May 11, 2023 09:02
@codecov
Copy link

codecov bot commented May 11, 2023 •
edited
Loading

Codecov Report

Patch coverage: 63.75% and project coverage change: +0.03 🎉

Comparison is base (a422464) 27.66% compared to head (ad5a510) 27.69%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6056      +/-   ##
==========================================
+ Coverage   27.66%   27.69%   +0.03%     
==========================================
  Files        2940     2947       +7     
  Lines      180694   180839     +145     
  Branches    19596    19628      +32     
==========================================
+ Hits        49985    50086     +101     
- Misses     129975   130008      +33     
- Partials      734      745      +11
Impacted Files Coverage Δ
...ckages/cli/src/credentials/oauth2Credential.api.ts 0.00% <0.00%> (ø)
packages/core/src/OAuth2Helper.ts 20.00% <0.00%> (ø)
packages/core/src/NodeExecuteFunctions.ts 14.43% <8.33%> (-0.04%) ⬇️
...ckages/@n8n/client-oauth2/src/ClientOAuth2Token.ts 51.61% <51.61%> (ø)
packages/@n8n/client-oauth2/src/CodeFlow.ts 65.78% <65.78%> (ø)
packages/@n8n/client-oauth2/src/ClientOAuth2.ts 74.19% <74.19%> (ø)
packages/@n8n/client-oauth2/src/utils.ts 76.00% <76.00%> (ø)
packages/@n8n/client-oauth2/src/CredentialsFlow.ts 100.00% <100.00%> (ø)
packages/@n8n/client-oauth2/src/constants.ts 100.00% <100.00%> (ø)
packages/@n8n/client-oauth2/src/index.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

maspio
maspio previously approved these changes May 11, 2023
View reviewed changes
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@n8n-io n8n-io deleted a comment May 12, 2023
@netroy netroy requested a review from maspio May 16, 2023 13:59
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 77ac953 into master May 16, 2023
@netroy netroy deleted the n8n-3921-client-oauth2 branch May 16, 2023 14:31
This was referenced May 16, 2023
Closed
Closed
netroy added a commit that referenced this pull request May 17, 2023
@netroy
Revert "feat(core): Replace client-oauth2 with an in-repo package (#6056
0632743 
)"

This reverts commit 77ac953.
netroy added a commit that referenced this pull request May 17, 2023
@netroy
Revert "feat(core): Replace client-oauth2 with an in-repo package (#6056
1d7c0df 
)"

This reverts commit 77ac953.
@netroy netroy mentioned this pull request May 17, 2023
Merged
netroy added a commit that referenced this pull request May 17, 2023
@netroy
fix: Revert "Replace client-oauth2 with an in-repo package" (no-chang…
b7d30f3 
…elog) (#6265)

Revert "feat(core): Replace client-oauth2 with an in-repo package (#6056)"

This reverts commit 77ac953.
netroy added a commit that referenced this pull request May 17, 2023
@netroy @maspio
feat(core): Replace client-oauth2 with an in-repo package (#6056)
2a2f583 
Co-authored-by: Marcus <[email protected]>
MiloradFilipovic added a commit that referenced this pull request May 19, 2023
@MiloradFilipovic
Merge branch 'master' into feature/resource-mapping-component
1c9af71 
* master:
  fix(Google Calendar Node): All day option fix (#6274)
  feat(Gotify Node): Add support for self signed certificates (#6053)
  docs: Remove missed beta text from Notion node (no-changelog) (#6166)
  fix(OpenAI Node): Descriptive errors (#6270)
  fix(SSH Node): Replace ~ with /home/username (#6269)
  feat(core): Replace client-oauth2 with an in-repo package (#6266)
  🚀 Release 0.229.0 (#6267)
  fix: Revert "Replace client-oauth2 with an in-repo package" (no-changelog) (#6265)
  feat(Respond to Webhook Node): Move from Binary Buffer to Binary streaming (#5613)
  feat(core): Replace client-oauth2 with an in-repo package (#6056)
  fix(editor): Fix typo and change text sizes in ExecutionUsage component (no-changelog) (#6261)
@janober
Copy link
Member

janober commented May 25, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maspio maspio maspio approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netroy @janober @maspio