Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(editor): Do not run parallel jobs for a single spec #6052

Merged
merged 4 commits into from
Apr 21, 2023
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/e2e-reusable.yml
Original file line number Diff line number Diff line change
@@ -109,7 +109,9 @@ jobs:
strategy:
fail-fast: false
matrix:
containers: ${{ fromJSON(inputs.containers) }}
# If spec is not e2e/* then we run only one container to prevent
# running the same tests multiple times
containers: ${{ fromJSON( inputs.spec == 'e2e/*' && inputs.containers || '[1]' ) }}
steps:
- uses: actions/checkout@v3
with:
@@ -135,9 +137,9 @@ jobs:
install: false
start: pnpm start
wait-on: 'http://localhost:5678'
wait-on-timeout: 120 #
wait-on-timeout: 120
record: ${{ inputs.record }}
parallel: ${{ inputs.parallel }}
parallel: ${{ fromJSON( inputs.spec == 'e2e/*' && inputs.parallel || false ) }}
# We have to provide custom ci-build-id key to make sure that this workflow could be run multiple times
# in the same parent workflow
ci-build-id: ${{ needs.prepare.outputs.uuid }}
2 changes: 1 addition & 1 deletion .github/workflows/e2e-tests-pr.yml
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@ jobs:
if: always()
steps:
- name: E2E success comment
if: ${{!contains(github.event.pull_request.labels.*.name, 'community') || needs.run-e2e-tests.result == 'success' }}
if: ${{!contains(github.event.pull_request.labels.*.name, 'community') && needs.run-e2e-tests.result == 'success' }}
uses: peter-evans/create-or-update-comment@v3
with:
issue-number: ${{ github.event.pull_request.number }}