Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(editor): Add version controls settings (WIP) #6036

Merged
merged 12 commits into from
Apr 26, 2023
Merged

feat(editor): Add version controls settings (WIP) #6036

merged 12 commits into from
Apr 26, 2023

Conversation

cstuncsik
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Apr 20, 2023 •
edited
Loading

Codecov Report

Patch coverage: 60.31% and project coverage change: +0.53 🎉

Comparison is base (88724bb) 18.61% compared to head (cfac669) 19.15%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6036      +/-   ##
==========================================
+ Coverage   18.61%   19.15%   +0.53%     
==========================================
  Files        2584     2589       +5     
  Lines      116410   116874     +464     
  Branches    18183    18336     +153     
==========================================
+ Hits        21673    22389     +716     
+ Misses      94101    93846     -255     
- Partials      636      639       +3
Impacted Files Coverage Δ
packages/editor-ui/src/composables/useMessage.ts 26.15% <0.00%> (ø)
packages/editor-ui/src/api/versionControl.ts 47.22% <47.22%> (ø)
packages/editor-ui/src/stores/versionControl.ts 71.59% <65.75%> (-28.41%) ⬇️
packages/editor-ui/src/Interface.ts 100.00% <100.00%> (ø)

... and 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Apr 20, 2023
@cstuncsik
feat(editor): Adding version control settings (WIP)
f98366a
@cstuncsik
Merge remote-tracking branch 'origin/master' into pay-408-add-version…
edabd72 
…-control-settings

# Conflicts:
#	packages/editor-ui/src/plugins/i18n/locales/en.json
#	packages/editor-ui/src/stores/versionControl.ts
#	packages/editor-ui/src/views/SettingsVersionControl.vue
@cstuncsik
feat(editor): Adding version control settings (WIP)
3076db4
@cstuncsik
Merge remote-tracking branch 'origin/master' into pay-408-add-version…
22afdec 
…-control-settings

# Conflicts:
#	packages/editor-ui/src/components/MainSidebar.vue
@cstuncsik
Merge remote-tracking branch 'origin/master' into pay-408-add-version…
da0c34a 
…-control-settings
@cstuncsik
fix(editor): use rest api root path in version control
f914b73
@cstuncsik
fix(editor): adding preferences
eef9983
@cstuncsik
fix(editor): adding preferences
43a6aba
@cstuncsik cstuncsik marked this pull request as ready for review April 26, 2023 15:18
flipswitchingmonkey
flipswitchingmonkey approved these changes Apr 26, 2023
View reviewed changes
packages/editor-ui/src/api/versionControl.ts

const versionControlApiRoot = '/version-control';

export const initSsh = (context: IRestApiContext, data: IDataObject): Promise<string> => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these endpoints are still based on the mvp i think, which is not current any more.... (we can leave them in, but they won't work....)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I know, I just kept them to not to break the build and satisfy the type checker. I'll remove them in the upcoming chages.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit 0c9ce3a into master Apr 26, 2023
@cstuncsik cstuncsik deleted the pay-408-add-version-control-settings branch April 26, 2023 15:52
@janober
Copy link
Member

janober commented May 3, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flipswitchingmonkey flipswitchingmonkey flipswitchingmonkey approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cstuncsik @janober @flipswitchingmonkey