-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix n8n-checkbox alignment #6004
Conversation
alexgrozav
commented
Apr 18, 2023
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
@@ -190,6 +190,7 @@ | |||
position: relative; | |||
border: var.$checkbox-input-border; | |||
border-radius: var.$checkbox-border-radius; | |||
margin-top: 2px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: --spacing-5xs
😛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed this one! Can you reapprove? Thank you!
✅ All Cypress E2E specs passed |
✅ All Cypress E2E specs passed |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #6004 +/- ##
=======================================
Coverage 18.49% 18.49%
=======================================
Files 2563 2563
Lines 116018 116018
Branches 18118 18118
=======================================
Hits 21458 21458
Misses 93930 93930
Partials 630 630 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
✅ All Cypress E2E specs passed |
* fix: fix n8n-checkbox alignment * fix: use css variables in checkbox inner margin-top * test: update snapshots