Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix broken API permissions in public API #5978

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

krynble
Copy link
Contributor

@krynble krynble commented Apr 14, 2023

Github issue / Community forum post (link here to close automatically):
https://linear.app/n8n/issue/N8N-6326/api-n8n-node-normal-user-can-access-execution-data-for-other-workflows

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.15 🎉

Comparison is base (8474cd3) 17.92% compared to head (f8585c3) 18.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5978      +/-   ##
==========================================
+ Coverage   17.92%   18.07%   +0.15%     
==========================================
  Files        2539     2540       +1     
  Lines      115279   115391     +112     
  Branches    17966    17990      +24     
==========================================
+ Hits        20660    20860     +200     
+ Misses      93992    93903      -89     
- Partials      627      628       +1     
Impacted Files Coverage Δ
...icApi/v1/handlers/executions/executions.handler.ts 78.26% <0.00%> (+4.34%) ⬆️
...blicApi/v1/handlers/workflows/workflows.service.ts 90.56% <100.00%> (-1.60%) ⬇️

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@netroy netroy changed the title fix: Broken API permissions fix(core): Fix broken API permissions in public API Apr 14, 2023
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Apr 14, 2023
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 49d838f into master Apr 14, 2023
@netroy netroy deleted the n8n-6326-api-n8n-node-normal-user-can-access branch April 14, 2023 09:05
@janober
Copy link
Member

janober commented Apr 19, 2023

Got released with [email protected]

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants